Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors.Is support to the generated error types #1736

Open
1 task done
gwvandesteeg opened this issue Jan 9, 2024 · 1 comment
Open
1 task done

Add errors.Is support to the generated error types #1736

gwvandesteeg opened this issue Jan 9, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@gwvandesteeg
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

Migrating code to the newer preferred system of checking for errors using errors.Is instead of a attempt to cast the error to a specific type identified that the errors generated by viper do not support this functionality.

Proposed Solution

Ensure errors.Is is supported by all error types and include tests for these to verify functionality.

For those errors that wrap other errors or are of a struct type we need to add the Is(err error) method.

This allows errors to be checked using both the old and new system.

Alternatives Considered

The alternative is the old way of handling errors.

Additional Information

No response

@gwvandesteeg gwvandesteeg added the kind/enhancement New feature or request label Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant