fix: vip bug #389
Closed
fix: vip bug #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
ramin,
ninabarbakadze,
rootulp,
cmwaters and
staheri14
and removed request for
a team
|
going off the tests, I think simply downgrading is likely a better option |
|
so closing this in favor of celestiaorg/celestia-core#1312 |
evan-forbes
added a commit
to celestiaorg/celestia-core
that referenced
this pull request
Apr 18, 2024
## Description I think the aws dep bumped viper in the last tracing PR, and 1.18 has this issue spf13/viper#1706. we can do this or celestiaorg/cosmos-sdk#389 main uses v1.13 of viper, but 1.15 is the lowest we can use without a replace statement on this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't like this api, but this fixes this bug in viper 1.18