Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom pflags #1677

Open
1 task done
unguiculus opened this issue Nov 10, 2023 · 1 comment
Open
1 task done

Support for custom pflags #1677

unguiculus opened this issue Nov 10, 2023 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@unguiculus
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description

It is possible to create custom pflags by implementing the Value interface. The problem is that viper just calls ValueString() on value types it doesn't know about.

I implemented a custom StringToBool flag, which pflags unfortunately lacks. In order for this to work properly, I would need Viper to call a conversion function as is, e.g., done for stringToInt.

Proposed Solution

My suggestion would be to add an option to register custom conversion functions for value types.

func (v *Viper) RegisterValueTypeConvFunc(valueType string, confFunc func(val string) any)

If a function is registered for a value type, Viper would then call this function in the find method.

I would offer to work on this if there is interest.

Alternatives Considered

No response

Additional Information

No response

@unguiculus unguiculus added the kind/enhancement New feature or request label Nov 10, 2023
Copy link

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant