Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrum doesn't consider BIP21 URI invalid when it contains unknown required parameters #8781

Closed
kristapsk opened this issue Dec 27, 2023 · 1 comment · Fixed by #8789
Closed
Labels
bug 🐞 topic-invoice-payreq invoices and payment requests
Milestone

Comments

@kristapsk
Copy link

BIP21 says:

Variables which are prefixed with a req- are considered required. If a client does not implement any variables which are prefixed with req-, it MUST consider the entire URI invalid. Any other variables which are not implemented, but which are not prefixed with a req-, can be safely ignored.

Electrum seems to be ignoring that. With test URI bitcoin:TB1QXJ6KVTE6URY2MX695METFTFT7LR5HYK4M3VT5F?amount=0.00100000&label=test&req-test=1 instead of giving error to the user (note req-test=1 parameter), it is parsed successfully.

image

In comparsion - Bitcoin Core GUI, Wasabi Wallet, JoinMarket and others will give error.

Current BIP77 Payjoin v2 draft specifies new parameter req-pj where receiver signals that he is ok receiving only payjoins, not simple sends. Electrum would silently ignore that.

@SomberNight SomberNight added bug 🐞 topic-invoice-payreq invoices and payment requests labels Dec 28, 2023
@SomberNight SomberNight added this to the backlog milestone Dec 28, 2023
@SomberNight
Copy link
Member

ACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 topic-invoice-payreq invoices and payment requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants