Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST date folk patterns #332

Open
thomasdowell opened this issue Mar 28, 2022 · 1 comment
Open

DST date folk patterns #332

thomasdowell opened this issue Mar 28, 2022 · 1 comment

Comments

@thomasdowell
Copy link

Yesterday, the clocks went forward 1 hour in the UK. The tomorrow function now moves to the Europe/London timezone incorrectly:

  • spacetime.today().goto("Europe/London").d returns 2022-03-28T00:00:00.000Z (correct)
  • spacetime.tomorrow().goto("Europe/London").d returns 2022-03-29T01:00:00.000Z (incorrect)

I am using version 6.15.1, so please accept my apologies if this issue has already been fixed. If not, then to ensure you understand when the clocks change in the UK, I have copied the following from the UK government's website (https://www.gov.uk/when-do-the-clocks-change):

In the UK the clocks go forward 1 hour at 1am on the last Sunday in March (yesterday), and back 1 hour at 2am on the last Sunday in October.

The period when the clocks are 1 hour ahead is called British Summer Time (BST). There’s more daylight in the evenings and less in the mornings (sometimes called Daylight Saving Time).

When the clocks go back, the UK is on Greenwich Mean Time (GMT).

@spencermountain
Copy link
Owner

hey thomas, yeah, the current version has up-to-date dst change-over times, you can see it here

I am going to do that this summer - and i'd really like some help. The '2nd sunday' stuff is surprisingly hard to come-across, for different timezones. Right now we have to keep updating the library. I've started working on organzing the dst times by '2nd sunday' patterns here if you were inclined to help.

Short answer - an update will work for now, long answer, i'm working on it!

@spencermountain spencermountain changed the title tomorrow() doesn't move to Europe/London timezone correctly DST date folk patterns Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants