Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toms params/result metadata #742

Open
chutuananh2k opened this issue Apr 5, 2024 · 2 comments
Open

Toms params/result metadata #742

chutuananh2k opened this issue Apr 5, 2024 · 2 comments
Labels
feature New feature or request

Comments

@chutuananh2k
Copy link

chutuananh2k commented Apr 5, 2024

  • Tome should define return type as well.
  • Params/return metadata should provide a presentation field, borrow from html. For ex:
paramdefs:
    - name: path
      type: string
      view: input
      label: Absolute file path
      placeholder: "/etc/passwd"
resultdefs:
    - name: file
      type: binary
      view: img
      label: Screenshot
      placeholder:"spinner.png"

Or we can leverage protobuf to define params/result. It will make gui to generate form input and output much easier.

@chutuananh2k chutuananh2k added the feature New feature or request label Apr 5, 2024
@hulto
Copy link
Collaborator

hulto commented Apr 5, 2024

Great idea.
And I think we've kinda started going down the protobuf route you're thinking of.
We've added a number of types like File, Process, and Credential which you can create from the agent using the report library.
We don't have any UI components that take advantage of them yet but are developing components to explore Process trees, and File trees in the UI instead of just relying on the Text Output.
So far the "structured" data I think is only used in the UI as TextOutput and ErrorOutput. But that's also pretty new.

@hulto
Copy link
Collaborator

hulto commented Apr 5, 2024

Here's where the current types are defined.

https://github.com/spellshift/realm/blob/main/tavern/internal/c2/proto/eldritch.proto

Here's the eldritch docs to report objects to the backend.

https://docs.realm.pub/user-guide/eldritch#report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants