Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug, using sliding eval with batch size larger than 1 on each gpu #57

Open
fuchangjie opened this issue Apr 3, 2020 · 2 comments
Open

Comments

@fuchangjie
Copy link

evaluate.py in branch pytorch-1.1
line 134 and line 135
you only use the prediction result of the first image, but treat it as the result of the remaining images in the same batch, in line 136. so something goes wrong when evaluate with batch size larger than 1.
you should modify it with
prediction = padded_prediction[:, 0:img.shape[2], 0:img.shape[3], :]
and
count_predictions[:, y1:y2, x1:x2] += 1

@ybchen97
Copy link

ybchen97 commented Feb 8, 2021

@fuchangjie Hey, thank you so much for finding this bug!

@ironcadiz
Copy link

I wrote #55 like a year ago addressing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants