You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently found an fdescribe checked into a project. Our continuous integration showed all the tests as passing, so it looked like everything was in good order even though only about 2% of tests were being run.
I'm wondering if it would make sense to, when an fdescribe or fit are in the suite, mark other tests as either failing or pending to make it more obvious that only a subset of the tests were run.
(Yes, I'll be adding a Danger rule to prevent this in the future...)
The text was updated successfully, but these errors were encountered:
dbgrandi
changed the title
Should 'fit' and 'fdescribe' have other tests show up as pending/failing?
Should fit/fdescribe have other tests show up as pending/failing?
Jan 22, 2017
I recently found an
fdescribe
checked into a project. Our continuous integration showed all the tests as passing, so it looked like everything was in good order even though only about 2% of tests were being run.I'm wondering if it would make sense to, when an
fdescribe
orfit
are in the suite, mark other tests as either failing or pending to make it more obvious that only a subset of the tests were run.(Yes, I'll be adding a Danger rule to prevent this in the future...)
The text was updated successfully, but these errors were encountered: