Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should fit/fdescribe have other tests show up as pending/failing? #215

Open
dbgrandi opened this issue Jan 22, 2017 · 0 comments
Open

Should fit/fdescribe have other tests show up as pending/failing? #215

dbgrandi opened this issue Jan 22, 2017 · 0 comments

Comments

@dbgrandi
Copy link

dbgrandi commented Jan 22, 2017

I recently found an fdescribe checked into a project. Our continuous integration showed all the tests as passing, so it looked like everything was in good order even though only about 2% of tests were being run.

I'm wondering if it would make sense to, when an fdescribe or fit are in the suite, mark other tests as either failing or pending to make it more obvious that only a subset of the tests were run.

(Yes, I'll be adding a Danger rule to prevent this in the future...)

@dbgrandi dbgrandi changed the title Should 'fit' and 'fdescribe' have other tests show up as pending/failing? Should fit/fdescribe have other tests show up as pending/failing? Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant