Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class information to EXPDescribeObject #177

Closed
manuyavuz opened this issue Oct 28, 2015 · 5 comments
Closed

Add class information to EXPDescribeObject #177

manuyavuz opened this issue Oct 28, 2015 · 5 comments

Comments

@manuyavuz
Copy link

Hi,

When a string value is received while an NSURL value expected, fail error message would be like this:

expected: http://myurl.com, got: http://myurl.com

This is because EXPDescribeObject uses -description method of nsobject, which prints string value of url for NSURL class.

Would adding also class type of values be appropriate? This way, description message could be more descriptive.

I can help with a PR if this is a proper improvement for you.

@orta
Copy link
Member

orta commented Oct 28, 2015

This should be in: #168

Are you up to date?

@manuyavuz
Copy link
Author

I'm using v1.0.3 coming from cocoapods. Isn't it included in that release yet? If so, I can use :head version.

@orta
Copy link
Member

orta commented Oct 28, 2015

Would recommend :head- once #175 is in I'll do a version bump etc

@manuyavuz
Copy link
Author

Great.

Thx for the info @orta, and sorry for duplicate :(

@orta
Copy link
Member

orta commented Oct 28, 2015

Not a problem, glad to see we had the same issue.

@orta orta closed this as completed Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants