Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Version id (fka commit id) no longer accessible in viewer - Add "Copy Latest Version ID" to Model Card Actions #2243

Open
5 tasks done
stephenburgess8 opened this issue May 3, 2024 · 0 comments
Labels
enhancement New feature or request question

Comments

@stephenburgess8
Copy link

stephenburgess8 commented May 3, 2024

Prerequisites

What package are you referring to?

frontend-2 only

Is your feature request related to a problem? Please describe.

In the previous version of the speckle server, the commits page provided a view of the commit including, crucially, the commit id. Information about that can be seen on this documentation page: https://speckle.guide/user/web.html

image

In this image from that page, the "id" at the top refers to the id of the commit (now I believe this is called the version id). In the new version of the Speckle Server frontend, there is no equivalent view of the old "Expand Data View" of the commit object. (note: please let me know if it is available and is something that I've missed).

When using specklepy, it's necessary to know the "commit id" to get the latest model. Our team had developed a workflow where we grabbed the latest commit ID from the expanded data view of the commit object when getting a project from our server instance. It would be nice to be able to access the version id in a way similar to how we used to access the commit id when we developed that workflow.

Describe the solution you'd like

It would be nice would be to add a command to "copy the latest version ID" to the actions on the model card on the project models page.

Screenshot 2024-05-03 at 3 10 50 PM

On the Models page for the Project, each Model (fka branch) has a drop down with options to copy the model id and the link. Since this model (branch) currently has its HEAD at the latest commit/version, it would make sense in my mind to provide a way for the user to copy the commit id at HEAD.

Describe alternatives you've considered

If it would be easier to make the version id copy accessible on the ViewerResourcesViewerCard that might work. That's the view showing the graphical list of versions for a model

The latest version id is used in the calculation of the props for each ViewerResourcesViewerCard. If it's accessible there I would assume it should be accessible elsewhere, hence my suggestion of adding it to the Model card dropdown..

:is-latest-version="version.id === latestVersionId"

I found out that the version id is used here because the latest version id is actually embedded in the url of the preview image.

Screenshot 2024-05-03 at 3 37 17 PM

The other alternative I've considered is a purely programmatic one in python. However it's possible others may find utility from having the latest version ID easily accessible in the speckle server frontend, so I wanted to propose it.

Additional context

I have experience working with Vue so I'd be willing to give this solution a shot if that would help.

Thanks for your work on this project.

Related issues or community discussions

I searched issues and community discussions but I couldn't find another reference to this.

@stephenburgess8 stephenburgess8 added enhancement New feature or request question labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question
Projects
None yet
Development

No branches or pull requests

1 participant