Bug: ObjectLoader caches error responses as legitimate content

[gouldingken]

When using ObjectLoader, if the object ID does not match the streamID, you will see an error like this because it tries to directly parse the server response:

"Failed to "... is not valid JSON

Once the ID issue is fixed, the ObjectLoader should be able to load the data from the object ID. However when using the cache, the object ID for the "Failed to" error message is stored in the cache so the fix will not be successful.

Solution

In ObjectLoader: implement better handling of error messages from the server and do not store these in the cache.

The JSON parse error is coming from line:

speckle-server/packages/objectloader/src/index.js

Line 294 in c2085d6

return { id: pieces[0], obj: JSON.parse(pieces[1]) }

The cache issue could be solved by checking the validity of objects before placing in the cache, but more robust error handling is likely preferable:

speckle-server/packages/objectloader/src/index.js

Line 556 in c2085d6

store.put(idAndData[1], idAndData[0])