Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoutingMiddleware should sort paths #1879

Open
karisN opened this issue Feb 13, 2024 · 1 comment · May be fixed by #1898
Open

RoutingMiddleware should sort paths #1879

karisN opened this issue Feb 13, 2024 · 1 comment · May be fixed by #1898
Labels
enhancement good first issue PR welcome We would welcome and review a PR addressing this issue

Comments

@karisN
Copy link

karisN commented Feb 13, 2024 •
edited

Connexion middleware sorts all available APIs from most specific to least because of starlettte's routing behavior

connexion/connexion/middleware/main.py

Line 334 in 5d7eb0b

self.apis = utils.sort_apis_by_basepath(self.apis)

Similar sorting algorithms should be done within an api's routes in the RoutingMiddleware
@RobbeSneyders
Copy link
Member

This is a good suggestion. We already have the functionality available, just need to call it at the right place.

@RobbeSneyders RobbeSneyders added enhancement good first issue PR welcome We would welcome and review a PR addressing this issue labels Feb 13, 2024
kosciCZ added a commit to kosciCZ/connexion that referenced this issue Mar 18, 2024
@kosciCZ
Sort routes in RoutingMiddleware
d0a4d29 
Fixes spec-first#1879
@kosciCZ kosciCZ linked a pull request Mar 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue PR welcome We would welcome and review a PR addressing this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort routes in RoutingMiddleware kosciCZ/connexion
2 participants
@karisN @RobbeSneyders