Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABNF grammar of Annex D and case-sensitivity #922

Open
pandatix opened this issue Apr 18, 2024 · 0 comments · May be fixed by #960
Open

ABNF grammar of Annex D and case-sensitivity #922

pandatix opened this issue Apr 18, 2024 · 0 comments · May be fixed by #960
Assignees

Comments

@pandatix
Copy link

Hey, I echo to #664 and the discussions on the ABNF grammar described as part of SPDX v3.0.

Given RFC 5234 Section 2.3 "Terminal Values":

ABNF strings are case insensitive [...]

This imply that "TEST" could produce "test", "tEsT", "TEST", and so on.
As this was not clear for most of the reviewers and later on the users of the RFC, the IETF published RFC 7405.

Nevertheless, the current ABNF grammar contains the alternation group ( "WITH" / "with" ) that produces the same results.
I suggest this alternation group is either removed to enhance readability OR replaced by ( %s"WITH" / %s"with" ) as in my understanding it better fits the idea of rule compound-expression.
The same goes on for AND and OR.

Moreover, this should also be clarified for "DocumentRef-", "LicenseRef-" and "AdditionRef-" which should be prefixed by %s.

@zvr zvr self-assigned this May 4, 2024
@zvr zvr linked a pull request May 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants