Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ontology/ directory is no longer updated - suggest deletion #937

Open
bact opened this issue Apr 23, 2024 · 6 comments
Open

ontology/ directory is no longer updated - suggest deletion #937

bact opened this issue Apr 23, 2024 · 6 comments

Comments

@bact
Copy link
Contributor

bact commented Apr 23, 2024

Content in https://github.com/spdx/spdx-spec/tree/development/v3.0.1/ontology is outdated.

One of the files (ontology/model.plantuml) was generated by spec-parser on 2024-02-22, before the release of 3.0 (2024-04-15).

It contains outdated concepts like Software/isDirectory and Dataset/sensitivePersonalInformation; also does not contain new concepts like Dataset/DatasetPackage and AI/energyUnit.

The ontology live on spdx.org is well updated. All these files are good:

Should we update this ontology/ directory or should we just delete it to avoid confusion?

@zvr
Copy link
Member

zvr commented Apr 23, 2024

Every run of the spec-parser generates an updated ontology in all formats, including the PlantUML diagram.

The generated files should be copied in the ontology directory.

@bact
Copy link
Contributor Author

bact commented Apr 23, 2024

How we are going to communicate about these "alternatives"? (Like, when to use which source)

  1. https://spdx.org/rdf/3.0.0/spdx-model.ttl (official)
  2. https://spdx.github.io/spdx-3-model/model.ttl
  3. https://github.com/spdx/spdx-spec/blob/development/v3.0.1/ontology/ontology.rdf.ttl

I realized that there should be at least two sources: one is stable (generated at release for public use), another is for development (generated frequently for testing/development).

The stable one should be at spdx.org (1) and all spec/doc should point to that new IRIs.

The question is probably where should be the source for the development.
For example, in spdx-3-model repo (2) or in spdx-spec repo (3).

Once decided to pick one, we should delete another to avoid confusion.
Also after that, README and etc should be updated to make it clear that this is unstable.

The current situation is a not very friendly for new comer.

The same concern of having multiple sources of truth (and not keep them updated) that happens here for spdx-spec repo goes to spdx-3-model repo as well. See: spdx/spdx-3-model#726

@goneall
Copy link
Member

goneall commented Apr 23, 2024

From the tech call - we agreed the ontology directory can be deleted.

The gh-pages version is being generated from model repo.

@goneall
Copy link
Member

goneall commented Apr 23, 2024

@zvr - let me know if you agree that it can be deleted

@zvr
Copy link
Member

zvr commented Apr 23, 2024

@goneall I admit that I like having a directory where one can see everything as files, as we had until now at https://github.com/spdx/spdx-spec/tree/development/v2.3/ontology

Having the individual files available elsewhere is useful but not equivalent.

But maybe I misunderstood what you wrote. Was the question to me about the ontology directory here? Or the gh-pages stuff in spdx-3-model? Reading the minutes it seems only deletion of spdx-3-model/gh-pages is mentioned.

Anyway, my views:

  • delete the spdx-3-model gh-pages stuff
  • keep the ontology directory here and populate it with the RDF ontology in different forms, etc.
  • also have the diagrams (both automatically generated and hand-curated ones) somewhere in the spdx-spec repo.

(and remember, we still have to generate RDF documentation and publish that one)

@goneall
Copy link
Member

goneall commented Apr 23, 2024

If we want to keep this directory, we should have a CI which copies any generated files or original files from the spdx-3-model repo. Doing it manually is leading to omissions and inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants