Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command responses should carry status code #4

Open
SalvatoreDiGirolamo opened this issue Jun 9, 2021 · 0 comments
Open

Command responses should carry status code #4

SalvatoreDiGirolamo opened this issue Jun 9, 2021 · 0 comments

Comments

@SalvatoreDiGirolamo
Copy link
Collaborator

If a handler issues a buggy command (e.g., to an undefined command interface) then the command request gets lost and no response is sent back.

We should:

  • (1) add an error bit to the command response;
  • (2) have a "sink" command interface that replies with responses flagged as errors;
  • (3) propagate success/fail status to the handler whenever it tests/waits for a command.

What happens if a handler issued a buggy command and then exits without checking? We should probably send an event to the host in this case. This would probably make (3) redundant because we shouldn't spend too much time into the handlers, e.g., checking for status codes: if sth goes wrong, it could be enough to signal this to the host via an event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant