Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Simplify pass (ConstantPropagation) #1538

Open
edopao opened this issue Feb 28, 2024 · 1 comment
Open

Error in Simplify pass (ConstantPropagation) #1538

edopao opened this issue Feb 28, 2024 · 1 comment

Comments

@edopao
Copy link
Collaborator

edopao commented Feb 28, 2024

The Simplify pass introduces an error in the attached SDFG: sdfg1_before_simplify.json

The error is introduces by ConstantPropagagation subpass. See the SDFG before (sdfg2_before_constant_propagation.json) and after (sdfg3_after_constant_propagation.json) applying ConstantPropagagation.

@edopao
Copy link
Collaborator Author

edopao commented Feb 29, 2024

I should probably add that the attached SDFG is quite simple, don't be worry of opening it. The error is introduced in the tasklet that writes to the output array. What happens is that ConstantPropagation propagates the symbol assignment on the false-branch edge to the output write. The problem is that it ignores the symbol assignment on the true-branch.

Before ConstantPropagation:
image

After ConstantPropagation:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant