You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When loading an sme file with v1.1.0, the simulation options are not correctly imported
To Reproduce
Open built-in brusselator model, save as sme file, open this file, look at simulation options
Expected behavior
Simulation options should be saved & re-imported on load.
Screenshots
before saving:
after saving & re-loading model:
log output shows the values are correctly stored as xml annotation in the saved model, so presumably something is going wrong with the conversion from xml to Settings;
This is a reincarnation of the bug we had with symengine where doubles were sometimes mysteriously incorrectly parsed, and is caused by Qt setting the locale, which if e.g. DE breaks strtod (see symengine/symengine#1566)
For now we can apply the same workaround as for symengine: temporarily set the locale to the C one while importing settings from xml
- temporarily set locale to C while reading/writing xml settings
- avoids locale affecting how doubles are read/written (e.g. 3.12 -> 3 if locale is DE, etc)
- resolves#535
- temporarily set locale to C while reading/writing xml settings
- avoids locale affecting how doubles are read/written (e.g. 3.12 -> 3 if locale is DE, etc)
- resolves#535
- temporarily set locale to C while reading/writing xml settings
- avoids locale affecting how doubles are read/written (e.g. 3.12 -> 3 if locale is DE, etc)
- resolves#535
Describe the bug
When loading an sme file with v1.1.0, the simulation options are not correctly imported
To Reproduce
Open built-in brusselator model, save as sme file, open this file, look at simulation options
Expected behavior
Simulation options should be saved & re-imported on load.
Screenshots
before saving:
after saving & re-loading model:
log output shows the values are correctly stored as xml annotation in the saved model, so presumably something is going wrong with the conversion from xml to Settings;
The text was updated successfully, but these errors were encountered: