Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd tier sbom #39

Open
sparrell opened this issue Oct 20, 2020 · 6 comments
Open

2nd tier sbom #39

sparrell opened this issue Oct 20, 2020 · 6 comments

Comments

@sparrell
Copy link
Owner

looking at first hop cyclonedx json sbom determine what is missing (from hex sbom or from manually looking at dependencies and/or build logs) and either add or make a subtending sbom.

Use https://sbom.democert.org/sbom/ to manually make sboms for 2nd tier (unless using hex sbom is easier but issue is json vs xml and hex sbom doesn't support cyclonedx with relationships and with json)

@sparrell sparrell created this issue from a note in CybersecurityAutomationWorkshop (Next up - Sigu) Oct 20, 2020
@sparrell sparrell added the -Maha label Oct 20, 2020
@sigu sigu moved this from Next up - Sigu to In progress - Sigu in CybersecurityAutomationWorkshop Nov 22, 2020
@sigu sigu assigned WanjikuMac and TraceyOnim and unassigned sigu and sparrell Nov 22, 2020
@sigu
Copy link
Collaborator

sigu commented Nov 22, 2020

Confirm that the current implementation can do 2nd tier for bot npm and hex packages

@WanjikuMac
Copy link
Collaborator

Confirmed! the boms generated contain 2nd tier deps for hex packages, the npm specified deps don't have 2nd tier deps (confirmed here), this is both in xml and json outputs.

@sigu
Copy link
Collaborator

sigu commented Dec 8, 2020

The link you provided https://www.npmjs.com/package/package, leads to a totally different package.
How did you confirm that the npm package dont have 2nd tier deps?

@WanjikuMac
Copy link
Collaborator

@sigu under that link when you look at the dependencies tab, you'll find that the core dependencies used under npm have no 2nd tier dependencies. Let me know if this makes sense.

@sigu
Copy link
Collaborator

sigu commented Dec 8, 2020

Not really making sense. Let me attempt to explain what I understand by 2nd tier dependency.

Have a look at a dependency called @babel/core, it's on your dev dependancies

This is one dependency that has other dependencies too

  • @babel/parser link
  • @babel/template link
  • @babel/traverse link
  • and many others

The dependencies listed above are considered 2nd tier dependencies (our dependency has them as a dependency)

@WanjikuMac
Copy link
Collaborator

I will generate a new bom file for the npm deps including the devdeps and then give an update on whether the 2nd tier is catered for. Thank you for flagging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants