Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers should not be shown as errors #32

Open
laritakr opened this issue Oct 19, 2016 · 2 comments
Open

Numbers should not be shown as errors #32

laritakr opened this issue Oct 19, 2016 · 2 comments
Labels
bug

Comments

@laritakr
Copy link

Currently the digits 0 through 9 do not show as errors, but anything 10 or higher does. Either number highlighting as errors should show according to the rules for writing numbers ( http://www.grammarbook.com/numbers/numbers.asp ), or they shouldn't be highlighted at all.
@laritakr laritakr mentioned this issue Oct 19, 2016
Closed
@WesCossick WesCossick added the bug label Oct 20, 2016
This was referenced Jan 17, 2017
Closed
Open
@mxgl
Copy link

mxgl commented Feb 5, 2020

It'd be nice to see this solved... though the odds of it seem low now

@edemaine
Copy link

edemaine commented Feb 5, 2020

It's fixed in PR #34. A fork with this and other changes is available on Github and NPM.

@eddiekrystowski eddiekrystowski mentioned this issue Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
4 participants
@edemaine @WesCossick @laritakr @mxgl