Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2C_BUFFER_LENGTH value differs with Wire.h #28

Open
pabloandresm opened this issue Jul 17, 2020 · 0 comments
Open

I2C_BUFFER_LENGTH value differs with Wire.h #28

pabloandresm opened this issue Jul 17, 2020 · 0 comments

Comments

@pabloandresm
Copy link

In case if ESP32, for example, the I2C_BUFFER_LENGTH is 128, and in that case you set it to 32 in this line:

#define I2C_BUFFER_LENGTH 32

Maybe you should consider, instead of #else ==>"#define I2C_BUFFER_LENGTH 32"
doing something like
#else
#ifndef I2C_BUFFER_LENGTH
#define I2C_BUFFER_LENGTH 32
#endif
#endif

so in the example of ESP32, where I2C_BUFFER_LENGTH is alreade defined to 128, will not interfere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant