Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials "How to normalize" improvements. #1897

Closed
giovp opened this issue Jul 15, 2020 · 2 comments
Closed

Tutorials "How to normalize" improvements. #1897

giovp opened this issue Jul 15, 2020 · 2 comments
Labels
feature New work

Comments

@giovp
Copy link

giovp commented Jul 15, 2020

Is your feature request related to a problem? Please describe.
These points refers to the tutorial on normalization strategies

  • Tutorials on normalization are really well made, but having the images alongside the text would greatly improve the readability.
  • The tutorial on normalizing by matching histograms is really nice for clearly showing when not to do it, but at least one example where the histograms match, and so it would be appropriate to use that normalization strategy, would be useful (especially since, it seems to me, is really knowledge-based and analyst without much experience would not have that intuition).

Describe the solution you'd like
Images alongside text in the tutorial

Describe alternatives you've considered
Running the tutorials on a local jupyter instance it's definitely fine, and works well. Feel free to disregard this if the motivation for this choice is already explained somewhere else (and i missed it).

Additional context

This issue references the JOSS submission openjournals/joss-reviews#2440

@giovp giovp added the feature New work label Jul 15, 2020
@neuromusic
Copy link
Collaborator

Thank you for the suggestions, @giovp!

This is due to the resource constraints of ReadTheDocs rendering the tutorials... We're tracking this (and exploring alternatives) in #1865

at least one example where the histograms match, and so it would be appropriate to use that normalization strategy, would be useful

That's a good suggestion. We'll see what we can do. cc @mattcai

@giovp
Copy link
Author

giovp commented Jul 17, 2020

Great, thank you! Did not notice the open issue. Nevermind, I think just running tutorials locally is also totally fine.

Regarding the example, I think it would improve readability and clarity but really marginal. what is there is already great, thank you!

@giovp giovp closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New work
Projects
None yet
Development

No branches or pull requests

2 participants