-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify need for v3yangle, vparity in L3 pipeline #1167
Comments
This issue is tracked on JIRA as RCAL-834. |
Comment by Jonathan Eisenhamer on JIRA: The sole place where the wcsinfo is used is in stcal.alignment.util._generate_tranform This routine creates an A couple of approaches can be taken: Modification of stcal: romancal-specific: The transform can be pre-calculated in romancal's make_output_wcs. Passing the transform in through the Unless otherwise dictate, Jonathan Eisenhamer will take the romancal-specific path. |
Could you check whether JWST actually uses this? I think our goal is for eventually Webb++ to start using stcal.alignment, but currently I think Roman is the only user. i.e., I think that if we think the _generate_transform API isn't right, we have flexibility to change it. |
These are used to determine the roll angle |
Sorry, I haven't tracked the full path, but looking at this briefly, _generate_transform is ~recomputing the WCS object we already have, and accepts a transform argument that we could imagine supplying it to avoid that path? |
Comment by Jonathan Eisenhamer on JIRA: After discussions with Eddie Schlafly , this issue is being closed without further work modulo the following:
|
The exposure level pipeline doesn't presently use the v3yangle or vparity keywords, though it may need to in the future when setting the telescope pointing. The mosaicing pipeline does use these keywords, however, and it's not obvious to me that it needs to; the WCS object contains all the information that should be needed. We should investigate whether these keywords are actually required.
The text was updated successfully, but these errors were encountered: