Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaussianAperture ignores pupil_diam #475

Open
retroexpress opened this issue Dec 7, 2021 · 2 comments
Open

GaussianAperture ignores pupil_diam #475

retroexpress opened this issue Dec 7, 2021 · 2 comments

Comments

@retroexpress
Copy link

It seems the pupil aperture is always 3*FWHM when I generate a Gaussian aperture, even when specified otherwise. Here are the plots for pupil_diam=0.01 and 1:

npix = 1024
wf = poppy.FresnelWavefront(0.1*u.m,wavelength=1550e-9,npix=npix,oversample=4)
wf *= poppy.GaussianAperture(w=2.28*15/2*u.mm,pupil_diam=1)

pupil0 01
pupil1

This is an awesome software package BTW.

@mperrin
Copy link
Collaborator

mperrin commented Dec 16, 2021

Hi @retroexpress - I just wanted to say, I/we did see this issue report. Apologies but we won't be able to look into it in any detail for some time (weeks, possibly months) - all our efforts right now are focused on supporting the immanent launch and commissioning of the Webb Space Telescope.

That said I am not quite sure what exactly is the issue you're reporting. In the example code given, the wavefront size is set when it's created:

wf = poppy.FresnelWavefront(0.1*u.m,wavelength=1550e-9,npix=npix,oversample=4)

That sets the array size and extent, independent of any optics.

To clarify, the pupil_diam parameter of an optic such as the GaussianAperture is only relevant in cases where there isn't a sampling defined by some Wavefront. For instance, if you try to display that aperture on its own via the .display() method, it needs to pick some pupil size to sample and display the optic on. But in the case you show here, the sampling is set first on the Wavefront object.

@retroexpress
Copy link
Author

retroexpress commented Dec 21, 2021

Hi Marshall, thanks for the reply. I understand you have some pretty big fish to fry for the foreseeable future so I really appreciate you taking the time. The issue I was reporting was that size of the aperture of the gaussian always seems fixed at 3FWHM, regardless of what I specify. Is pupil_diam not what is specifying the size of the circle in the phase plots? It certainly looks to be 3FWHM and I don't see how that could be coming from setting the wavefront size and sampling...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants