Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

think more about different PSF centering between Fresnel & Fraunhofer modes #291

Open
mperrin opened this issue Feb 11, 2019 · 0 comments
Open
Labels
enhancement New feature or request fresnel Issues related to the Fresnel propagation part of the code

Comments

@mperrin
Copy link
Collaborator

mperrin commented Feb 11, 2019

For historical reasons related to sampling choices in MFT vs. FFT algorithms, output PSF centerings are slightly different between Fraunhofer & Fresnel calculations for even number of pixels. Here I'm talking about where the PSF peak intensity is, in the ideal case with zero tilt etc.

  • Fraunhofer mode: PSF is centered in the exact middle of the output array, e.g. for 128^2 pixels, the PSF is centered at (63.5, 63.5), on the corner in between the 4 central pixels.
  • Fresnel mode: PSF is centered on (64, 64), on the integer pixel closest to the center but above it. (The 0,0 pixel after a fftshift operation)

This is fine enough but (a) the behavior should be documented more clearly, and (b) Various utility functions for display, radial profile computation, etc. should perhaps be updated to use the correct center for Fresnel mode PSFs. (c) Perhaps we should add some FITS keywords to output PSFs indicating where the correct center reference pixel is?

Overall this more like a subtle semantic issue, not an actual problem with the output PSF values.

@mperrin mperrin added enhancement New feature or request fresnel Issues related to the Fresnel propagation part of the code labels Apr 18, 2019
@mperrin mperrin added this to the Winter 2019 release milestone Aug 12, 2019
@mperrin mperrin modified the milestones: Winter 2019 release, 0.9.2 Jun 19, 2020
@mperrin mperrin removed this from the 1.0.0 milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fresnel Issues related to the Fresnel propagation part of the code
Projects
None yet
Development

No branches or pull requests

1 participant