Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out impossible SB <> SB and Flux <> Flux conversions in unit conversion plugin[BUG] #2876

Open
cshanahan1 opened this issue May 15, 2024 · 0 comments
Labels
bug Something isn't working needs-triage Issue opened via template and needs triaging

Comments

@cshanahan1
Copy link
Contributor

Jdaviz component

Cubeviz

Description

If you load a MJy / sr cube, in the unit conversion plugin there are some units listed as available that you can't actually convert to (e.g MJy / sr to bol / sr, or erg / cm**2ssr). The unit conversion (which, from what I understand, only applies to the displayed data, not updating data in the data collection?) appears to happen, the display label is changed, but the flux disappears from the spectrum viewer because the conversion wasn't successful. This has implications for other plugins as well that use the flux / sb unit (like moment maps).

I'm not sure if this issue is limited to SB <> SB, i imagine it exists as well for flux <> flux.

How to Reproduce

  1. Load cubeviz example notebook, which has data in MJy / sr
  2. Use unit conversion plugin to convert to one of the available units that is invalid, like bol / sr

Expected behavior

These invalid options shouldn't be listed as possibilities.

Browser

No response

Jupyter

No response

Software versions

No response

@cshanahan1 cshanahan1 added bug Something isn't working needs-triage Issue opened via template and needs triaging labels May 15, 2024
@cshanahan1 cshanahan1 changed the title Filter out impossible SB <> SB conversions in unit conversion plugin[BUG] Filter out impossible SB <> SB and Flux <> Flux conversions in unit conversion plugin[BUG] May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Issue opened via template and needs triaging
Projects
None yet
Development

No branches or pull requests

1 participant