Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_set_axes_lim called too many times when Imviz adjusts more than one limit at once #2746

Open
pllim opened this issue Mar 11, 2024 · 0 comments
Labels
bug Something isn't working imviz performance Performance related

Comments

@pllim
Copy link
Contributor

pllim commented Mar 11, 2024

for attr in ('x_min', 'x_max', 'y_min', 'y_max'):
self.add_callback(attr, self._set_axes_lim)

_set_axes_lim called too many times when Imviz adjusts more than one limit at once. Coupled with WCS look-ups every time it is called, this can lead to performance issues. Ideally, it should only be called once every time the viewer needs adjusting, taking into account all affected limits at once. However, given the async nature of things, no simple solution immediately jumps to mind.

xref #2649

🐱

@pllim pllim added bug Something isn't working imviz performance Performance related labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz performance Performance related
Projects
None yet
Development

No branches or pull requests

1 participant