Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Hide the pixel area options in aperture photometry if not applicable #2549

Open
eteq opened this issue Nov 1, 2023 · 1 comment
Open
Labels

Comments

@eteq
Copy link
Contributor

eteq commented Nov 1, 2023

Jdaviz component

Imviz

What is the problem this feature will solve?

The aperture photometry plugin (in batch or single mode) has a "Pixel area" option with the caption ""Pixel area in arcsec squared, only used if sr in data unit"". That's a bit distracting in the common case where sr are not in the data units.

Describe the desired outcome

This could be a toggle instead of an option that is mandatory but only sometimes used. It should be off by default unless the data units definitely have solid angle in them (becaues BUNIT is defined or whatever), which can be easily checked by looking at the physical_type of the units.

Additional context

🐱

@pllim pllim added feature Feature request UI/UX😍 imviz labels Nov 1, 2023
@pllim
Copy link
Contributor

pllim commented Nov 1, 2023

Hiding this requires exposing that value as a traitlet on the JS side but doable.

@pllim pllim changed the title [FEAT] Hide the pixel area options in aperture photometry if the [FEAT] Hide the pixel area options in aperture photometry not applicable Nov 1, 2023
@pllim pllim changed the title [FEAT] Hide the pixel area options in aperture photometry not applicable [FEAT] Hide the pixel area options in aperture photometry if not applicable Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants