Non-repeatable vmin vmax[BUG]

[cshanahan1]

Jdaviz component

Imviz

Description

This is a bug I noticed while reviewing #2513, but seems to have existed before.

If you open a new instance of imviz (after restarting notebook), the initial values of vmin and vmax for display occasionally change. With the imviz example data in the notebook, sometimes they are 0 and 0.56, and sometimes they are 0.11 and 0.62. The screenshots below come from creating an imviz instance, loading data, and opening plot options to view vmin/vmax (refreshing the notebook inbetween). It is non repeatable for some reason.

How to Reproduce

Using imviz example notebook, load data and look at vmin and vmax in plot options. Refresh and do this again a few times, and youll notice sometimes that the initial values change.

Expected behavior

For a given dataset, the initial values of vmin and vmax sound be the same every time.

Browser

Safari

[astrofrog]

This is due to the fact that glue will avoid loading all pixels from the data so actually only accesses a sub-sample of the data to determine the min/max. This is important because if you were to load in e.g. a 100Gb mosaic, you definitely wouldn't want to load in all the pixels just to determine the limits.

The question is, is the threshold for data size where this is happening too low? Or would you like to have some way to cache for a given filename what seed is used for the random sub-sampling of the array?

[pllim]

Personally, unless this is causing some analysis problems, I'd say just chuck it under Known Issues and move on. @cshanahan1 , what do you think?

[astrofrog]

As an aside (but somewhat related) I also wonder whether the limits need to be shown with so much precision? Changing the limits at the 5th significant figure isn't going to change the RGB values of the image in any significant way?

[pllim]

I agree. Maybe a .3e would be more than enough?

[astrofrog]

Or .3g for more readable numbers when close to 1

[pllim]

@astrofrog , is this something we have to patch in glue-jupyter?

[pllim]

Oh wait, maybe here but I dunno how to set format in the front-end. Maybe @kecnry knows.

jdaviz/jdaviz/configs/default/plugins/plot_options/plot_options.vue

Lines 439 to 448 in d033439

	<!-- for multiselect, show vmin/max here, otherwise they'll be in the "more stretch options" expandable section -->
	<glue-state-sync-wrapper v-if="multiselect" :sync="stretch_vmin_sync" :multiselect="multiselect" @unmix-state="unmix_state('stretch_vmin')">
	<v-text-field
	ref="stretch_vmin"
	label="Stretch VMin"
	v-model.number="stretch_vmin_value"
	type="number"
	:step="stretch_vstep"
	></v-text-field>
	</glue-state-sync-wrapper>

[kecnry]

I don't know of a way with vue, we could either do it with JS/CSS or on the Python side, but we can cross that bridge when we come to it.