You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once upon a time, there was a Simple Aperture Photometry plugin. Then a fairy dev appears and it is not so simple anymore. It has grown up to be a beautiful princess plugin. Unfortunately, this means radial profile plotting that is only meant for a simple case (one viewer, one data, one subset, at a time) no longer fits well in its workflow, making any future addition to its feature (e.g., choosing what function to fit to the radial profile, etc) difficult to implement on top of, say, batch mode.
Hereby, I propose that the radial profile plot be taken out and made into its own plugin.
Pros:
Simplify Aperture Photometry plugin logic, a lot.
Simplify future feature implementations for radial profile functionality.
Cons:
Yet another plugin.
Some shared code between radial profile and photometry will have to be duplicated, or we have to add a button for photometry plugin (when not in batch mode) to send data to radial profile plugin.
Open the can of worms that is labeled "should we also make local background calculation its own plugin?" Note the words "local" and "calculation," which is very different from "global" and "subtraction," because the latter requires reading the entire image into memory, and then even more memory to hold the background subtracted image.
Reporter: pllim
Once upon a time, there was a Simple Aperture Photometry plugin. Then a
fairydev appears and it is not so simple anymore. It has grown up to be a beautifulprincessplugin. Unfortunately, this means radial profile plotting that is only meant for a simple case (one viewer, one data, one subset, at a time) no longer fits well in its workflow, making any future addition to its feature (e.g., choosing what function to fit to the radial profile, etc) difficult to implement on top of, say, batch mode.Hereby, I propose that the radial profile plot be taken out and made into its own plugin.
Pros:
Cons:
🐱
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter.
The text was updated successfully, but these errors were encountered: