Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Radial Profile plot out of not-so-simple-anymore Aperture Photometry plugin #2493

Open
Jdaviz-Triage-Bot opened this issue Oct 4, 2023 · 0 comments
Labels
feature Feature request imviz plugin Label for plugins common to multiple configurations

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Oct 4, 2023

Reporter: pllim

Once upon a time, there was a Simple Aperture Photometry plugin. Then a fairy dev appears and it is not so simple anymore. It has grown up to be a beautiful princess plugin. Unfortunately, this means radial profile plotting that is only meant for a simple case (one viewer, one data, one subset, at a time) no longer fits well in its workflow, making any future addition to its feature (e.g., choosing what function to fit to the radial profile, etc) difficult to implement on top of, say, batch mode.

Hereby, I propose that the radial profile plot be taken out and made into its own plugin.

Pros:

  • Simplify Aperture Photometry plugin logic, a lot.
  • Simplify future feature implementations for radial profile functionality.

Cons:

  • Yet another plugin.
  • Some shared code between radial profile and photometry will have to be duplicated, or we have to add a button for photometry plugin (when not in batch mode) to send data to radial profile plugin.
  • Open the can of worms that is labeled "should we also make local background calculation its own plugin?" Note the words "local" and "calculation," which is very different from "global" and "subtraction," because the latter requires reading the entire image into memory, and then even more memory to hold the background subtracted image.

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter.

@pllim pllim added imviz feature Feature request plugin Label for plugins common to multiple configurations labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request imviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

No branches or pull requests

2 participants