Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the first frame upon an exposure time change in Hamamatsu camera #195

Open
ivalaginja opened this issue Apr 24, 2024 · 0 comments
Open
Labels
collaborators Worked on by external collaborator. Might need some extra help on code integration. hardware Integrate new hardware

Comments

@ivalaginja
Copy link
Collaborator

ivalaginja commented Apr 24, 2024

Question: does this faulty frame reappear when you change ROI, exposure time, gain or other settings?

So it turns out that we haven't paid much attention to the proper way of property setting with this camera - or the Allied Vision cameras. Some of the properties need the camera acquisition to be temporarily stopped, so I opened an issue for this for the AV service here: #183

For the Hamamatsu camera, only the exposure time can be changed while the camera is acquiring, the other properties need a temporary stop of the acquisition as well. Since that retriggers the acquisition loop, yes the faulty frame would appear again, but it would also be automatically discarded again in the current implementation. As for resetting the exposure time, I don't actually know how to catch the exact first frame after resetting it to figure out whether it's fine or not...

We only have our loaner camera for one more day and we won't be able to implement and test this before we have to send it back. We won't get our own camera for a while. My idea would be to open an issue an put a rework of the properties that need an acquisition halt into it (#194), akin to the issue for the Allied Vision cameras. And to open a separate issue to figure out how to test the first frame upon an exposure time change to decide whether it's fine or whether we need to throw it away too.

What do you say?

Originally posted by @ivalaginja in #163 (comment)

@ivalaginja ivalaginja added hardware Integrate new hardware collaborators Worked on by external collaborator. Might need some extra help on code integration. labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collaborators Worked on by external collaborator. Might need some extra help on code integration. hardware Integrate new hardware
Projects
None yet
Development

No branches or pull requests

1 participant