Move simple simulator and model from hicat-package2 to catkit2 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivalaginja
force-pushed
the
feature/move_simple_simulator_and_model
branch
from
1db9c0f
to
501fda9
Compare
ivalaginja
force-pushed
the
feature/move_simple_simulator_and_model
branch
from
08cdc89
to
0e40700
Compare
|
This is ready for review, although I don't really know how to make the test make more sense, and whether it's worth it. |
ehpor
reviewed
May 1, 2024
tests/test_optical_model.py
Outdated
| size1 = test_wf.intensity.shaped.shape[0] | ||
| size2 = test_wf.intensity.shaped.shape[1] | ||
|
|
||
| stream = DataStream.create('images', 'mod', 'float64', [size1, size2], 20) |
There was a problem hiding this comment.
I'm not sure why the data stream is needed here. This is a leftover from very early on, when I wanted to test an early version of the camera viewer UI.
The test looks fine to me. Basic functionality test and checks that the code doesn't crash. |
ivalaginja
force-pushed
the
feature/move_simple_simulator_and_model
branch
from
d2f435e
to
68a1b62
Compare
ivalaginja
force-pushed
the
feature/move_simple_simulator_and_model
branch
from
29d5f02
to
e987286
Compare
raphaelpclt
requested changes
May 17, 2024
ivalaginja
force-pushed
the
feature/move_simple_simulator_and_model
branch
from
e987286
to
a446d9d
Compare
|
@raphaelpclt all fair questions, I hope I answered them sufficiently, ready for a new review. Let me know if you'd need more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187.
Pair PR with https://github.com/spacetelescope/hicat-package2/pull/587.
Needs testing and converting the added test into a real test that pytest understands.