Fix datastream lifetime. #112
Open
+126
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was mistaken in my original thinking that this was a bug. However, this PR still adds error messages that will more clearly indicate errors in the future. In addition, this PR adds a test for datastream lifetime, which ensures that we do not deviate from the current expected behaviour. This will catch any bugs when rewriting parts of the datastream code in the future. |
RemiSoummer
previously approved these changes
Jul 1, 2023
There was a problem hiding this comment.
LGTM @ehpor, I have not run the test myself, but that sounds like a great idea to add that in case there is a problem later, especially in light of the recent issues we found on CI that are really had to debug without any additional info.
ehpor
force-pushed
the
bugfix/shared_memory_unlink
branch
from
cdc1f07
to
a55382a
Compare
RemiSoummer
dismissed
their stale review
We need to test this more extensively, so I don't want to merge accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a potential bug in data stream lifetime.(see comment below)Fixes #113.