Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle not working with Angular v1.5.0 and Angular Material v1.0.6 #26

Open
Spatlani opened this issue Mar 11, 2016 · 13 comments
Open

Toggle not working with Angular v1.5.0 and Angular Material v1.0.6 #26

Spatlani opened this issue Mar 11, 2016 · 13 comments

Comments

@Spatlani
Copy link

image

I am using the demo code. When I try to open the toggle menu, the arrow icon changes but the dropdown doesn't work.

Need Help!
Thanks.

@LockonF
Copy link

LockonF commented Mar 17, 2016

As of the latest version, line 309 of angular-material-sidenav.js has the following condition

if (!$mdSidenav('left').isOpen() && open) {
                            return;
}

I've managed to get the desired behaviour by commenting that specific line.

@nanoninja
Copy link

Thanks !
I had the same problem through bower...
This works by downloading the source via github and recovering the file to the root.

@Spatlani
Copy link
Author

Thanks, It works after commenting. Will it be fixed in later builds?

@bastianwegge
Copy link

What's the meaning of this anyway? I'd make a pull-request and just remove it, if it's doing trouble anyway.

@mateuo
Copy link

mateuo commented Mar 29, 2016

Thanks LockonF . It works for me

@tiste
Copy link

tiste commented Jun 6, 2016

Any fix on master soon?

Thanks @LockonF, works for me.

@sovanna
Copy link
Owner

sovanna commented Jun 6, 2016

gonna do the fix before the end of the day. Sorry guys for the late response.

@tiste
Copy link

tiste commented Jun 6, 2016

Great, thanks @sovanna

@tiste
Copy link

tiste commented Jun 9, 2016

Any news? @sovanna

@sovanna
Copy link
Owner

sovanna commented Jun 9, 2016

@tiste I've looked and start from the beginning but didn't arrive to reproduce the bug. did you have the bug ? or maybe I just don't understand the description.

I did :
git clone the project
cd demo
npm install
bower install
grunt serve
and the demo work perfectly

@tiste
Copy link

tiste commented Jun 9, 2016

It's not related to your demo but to projects which import a recent version of angular-material.

For instance, I use a 1.0.9 and it fails. Hope that helps.

@sovanna
Copy link
Owner

sovanna commented Jun 9, 2016

strange, I also angular-material 1.0.9, and I have the toggle menu, I click , the dropdown works.. don't understand the problem

@EkoAdiWijayanto
Copy link

@sovanna, i think this will solve the issue

if (!$mdSidenav('left').isLockedOpen() && !$mdSidenav('left').isOpen() && open) { return; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants