Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery should ignore # noqa lines #379

Open
3 tasks done
Bilbottom opened this issue Aug 20, 2023 · 1 comment
Open
3 tasks done

Sourcery should ignore # noqa lines #379

Bilbottom opened this issue Aug 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Bilbottom
Copy link

Checklist

  • This is a new feature, not a refactoring suggestion
  • I have checked for this feature in the Sourcery documentation
  • I have checked there are no open requests referencing the same feature

Description

This might be a design choice (in which case, close this immediately 😋), but currently Sourcery doesn't ignore lines with the # noqa trailing comment. Although # noqa isn't a recommended way of suppressing QA warnings, there are occasional places where it's helpful.

It would be awesome if both the CLI and the IDE interfaces would ignore lines with the # noqa trailing comment. A minimal example in PyCharm to show that this currently isn't the case is in the screenshot below:

image

@Bilbottom Bilbottom added the enhancement New feature or request label Aug 20, 2023
@bm424
Copy link
Contributor

bm424 commented Aug 21, 2023

Hi @Bilbottom! Thank you for this great suggestion, it's definitely something we'll consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants