Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report test coverage achieved by e2e tests to codecov #5211

Closed
felixfbecker opened this issue Aug 15, 2019 · 2 comments
Closed

Report test coverage achieved by e2e tests to codecov #5211

felixfbecker opened this issue Aug 15, 2019 · 2 comments
Assignees

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Aug 15, 2019

See https://www.philkrie.me/2018/07/04/extracting-coverage.html

This would allow us to track our progress in automating release testing and identify areas that are untested.

Since e2e coverage often doesn't test all possible cases and are not as rigorous as unit tests, they should be reported with the e2e flag to codecov, so they can be filtered by and show up separately in reports.

This would also allow us to detect unused CSS.

@felixfbecker
Copy link
Contributor Author

This turns out to be more difficult than expected because Puppeteer does not apply source maps to the coverage. It may be possible to map after the fact but it would need some work.

istanbuljs/puppeteer-to-istanbul#18
puppeteer/puppeteer#3570
istanbuljs/v8-to-istanbul#21

@felixfbecker
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant