Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Changes: Approved Status #6784

Open
johnwesonga opened this issue Apr 19, 2023 · 0 comments
Open

Batch Changes: Approved Status #6784

johnwesonga opened this issue Apr 19, 2023 · 0 comments

Comments

@johnwesonga
Copy link
Contributor

Chime has noticed that batch changes appear as approved in the UI when they are not able to be merged. This is b/c they have some weird code review requirements. Basically, for some repos the code has to be reviewed by the code owner. Someone else could approve review the PR but it cannot be merged until the code owner approves it.

Basically, while the PR is marked as review required in GitHub, it should not show up as approved in the batch changes UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant