Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move over SwiftNIO allocation integration tests #265

Open
fabianfett opened this issue May 21, 2020 · 3 comments
Open

Move over SwiftNIO allocation integration tests #265

fabianfett opened this issue May 21, 2020 · 3 comments

Comments

@fabianfett
Copy link
Contributor

We should verify be able to verify that we don't increase the number of needed allocations per request in AWSClient.

This should be made part of the CI.

An example how this can be achieved can be seen here:

https://github.com/fabianfett/pure-swift-json/tree/master/IntegrationTests/tests_04_performance
https://github.com/fabianfett/swift-base64-kit/tree/master/IntegrationTests

We probably need a setup in which we run the request against something. LocalStack? Create our own MockServer?

@adam-fowler what are your thoughts?

@adam-fowler
Copy link
Member

A mock server should do the trick.

@fabianfett
Copy link
Contributor Author

Depends on: #267

@adam-fowler
Copy link
Member

I had a look into this and found starting up each integration test took so long as it had to download all the dependencies. Need to find a better way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants