Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for spaceship-zsh-theme #1504

Closed
lokesh-krishna opened this issue Nov 7, 2017 · 5 comments
Closed

Support for spaceship-zsh-theme #1504

lokesh-krishna opened this issue Nov 7, 2017 · 5 comments
Labels

Comments

@lokesh-krishna
Copy link

Description

Could you please consider adding Spaceship ZSH as a prompt theme?

@belak belak added the Theme label Nov 8, 2017
@belak
Copy link
Collaborator

belak commented Nov 8, 2017

Looks like an interesting theme. Unfortunately, we're waiting on #1458 and #1483 before adding any new themes.

Additionally, we would need to wait for spaceship-prompt/spaceship-prompt#200 which removes oh-my-zsh as a dependency.

@lokesh-krishna
Copy link
Author

That looks really interesting for the future of Prezto. However, the oh-my-zsh dependency you're talking about has already been dropped or am I missing something?

@belak
Copy link
Collaborator

belak commented Nov 9, 2017

It was merged in the 3.0 branch but it doesn't look like there's been a release for it yet.

@belak
Copy link
Collaborator

belak commented Dec 11, 2017

I tried it out and submitted a few PRs because it seems to be broken when using the builtin zsh prompt loading:

spaceship-prompt/spaceship-prompt#274

spaceship-prompt/spaceship-prompt#275

Once at least the second one is in, I'll look at adding it to the contrib repo.

@belak
Copy link
Collaborator

belak commented Jan 18, 2018

3.0 was recently released and so it's been added to the prezto-contrib repo. Thanks for suggesting this theme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants