Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting prompt to sorin disconnects my shell #1137

Open
aliostad opened this issue Apr 29, 2016 · 4 comments
Open

Setting prompt to sorin disconnects my shell #1137

aliostad opened this issue Apr 29, 2016 · 4 comments

Comments

@aliostad
Copy link

aliostad commented Apr 29, 2016

Hi,

I have been using your great work through yadr and happily using sorin as my default prompt (and I love it). This has been working fine for me but today I was setting up a new Linux box and changing the default prompt (by editing zzzz_after.zsh in ~yadr/zsh) or creating a new file in .zsh.after and my zsh seems to be crashing and I get disconnected from the ssh.

As I said, this was working fine in previous machines I have set up. I am no linux god or anything like it, happy to report back any log, etc you need.

Thanks for a great project.

PS: I tried oliver and it worked. It seems it is only sorin (ironic isn't it) which has a problem.

@aliostad
Copy link
Author

Sorry no solution have been found yet. Can anybody respond?

@meastes
Copy link

meastes commented Jun 8, 2016

I have the same issue. It only happens over SSH. It appears to be related to the async process. It seems that the "zle reset-prompt" command is crashing my SSH session for some reason.

UPDATE: This is the same issue - zsh-users/zsh-autosuggestions#126
A workaround is to change the 'zle reset-prompt' command to 'zle .reset-prompt'

@rjcoelho
Copy link

Same problem when using sorin in Visual Studio Code Integrated Terminal. And @meastes 's suggested workaround worked for me.

--- a/modules/prompt/functions/prompt_sorin_setup
+++ b/modules/prompt/functions/prompt_sorin_setup
@@ -57,7 +57,7 @@ function prompt_sorin_git_info {
     _prompt_sorin_precmd_async_pid=0

     # Redisplay prompt.
-    zle && zle reset-prompt
+    zle && zle .reset-prompt
   fi
 }

@belak
Copy link
Collaborator

belak commented Nov 10, 2017

Are you still seeing this with the latest changes? We've updated how the async process works with the sorin prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants