Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook support? #98

Open
jbaugh opened this issue Sep 22, 2020 · 3 comments
Open

Webhook support? #98

jbaugh opened this issue Sep 22, 2020 · 3 comments
Labels
enhancement help wanted

Comments

@jbaugh
Copy link

jbaugh commented Sep 22, 2020

I might be missing something obvious, so I apologize if so, but I can't see where webhook support is implemented (if it is). If there is, can you point me in the right direction, and if not, do we have plans to add it? Thanks in advanced.
@sorentwo
Copy link
Owner

sorentwo commented Oct 1, 2020

@jbaugh I missed this question somehow, sorry for the delay. There isn't any webhook support built into the library currently. I've never made use of their webhooks and never had cause to implement them.

A PR would certainly be welcome, even if only for a subset of the potential events: https://developers.braintreepayments.com/guides/webhooks/overview

@jbaugh
Copy link
Author

jbaugh commented Oct 2, 2020

@sorentwo I think I'll work on that. I got it working for my use case, so I think I might be able to at least get something put together than can help :)

treble37 added a commit to treble37/braintree-elixir that referenced this issue Jul 3, 2021
@treble37
Add module for parsing and validating webhook events from Braintree
905ef70 
- Ensure compatiblity with pre-OTP-22 version as well as OTP-22 and
  beyond
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to sorentwo#98
treble37 added a commit to treble37/braintree-elixir that referenced this issue Jul 3, 2021
@treble37
Add module for parsing and validating webhook events from Braintree
4824142 
- Ensure compatiblity with pre-OTP-22 version as well as OTP-22 and
  beyond
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to sorentwo#98
treble37 added a commit to treble37/braintree-elixir that referenced this issue Jul 3, 2021
@treble37
Add module for parsing and validating webhook events from Braintree
dff47bf 
- Ensure compatiblity with pre-OTP-22 version as well as OTP-22 and
  beyond
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to sorentwo#98
treble37 added a commit to treble37/braintree-elixir that referenced this issue Jul 3, 2021
@treble37
Add module for parsing and validating webhook events from Braintree
8a9ba52 
- Ensure compatiblity with pre-OTP-22 version as well as OTP-22+
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to sorentwo#98
@treble37 treble37 mentioned this issue Jul 3, 2021
Merged
treble37 added a commit to treble37/braintree-elixir that referenced this issue Jul 3, 2021
@treble37
Add module for parsing and validating webhook events from Braintree
bfb04b3 
- Ensure compatiblity with pre-OTP-22 version as well as OTP-22+
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to sorentwo#98
treble37 added a commit to treble37/braintree-elixir that referenced this issue Jul 3, 2021
@treble37
Add module for parsing and validating webhook events from Braintree
459d0c0 
- Ensure compatiblity with pre-OTP-22 version as well as OTP-22+
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to sorentwo#98
@treble37
Copy link
Contributor

treble37 commented Jul 3, 2021 •
edited

@jbaugh @sorentwo - I ended up sharing some code I made for validation to check the initial webhook payload because I really wanted something like this for my use case, not sure if it overlaps with any of your proposed changes @jbaugh, but happy to find a way to collaborate if you'd like.

sorentwo pushed a commit that referenced this issue Jul 12, 2021
@treble37
Add module for parsing and validating webhook events from Braintree (#…
fee03b9 
…113)

* Add module for parsing and validating webhook events from Braintree

- Ensure compatiblity with pre-OTP-22 version as well as OTP-22+
- Right now, Braintree.Webhook#parse/2 returns the signature and decoded
  payload (an xml document embedded in a string) from Braintree for later post-processing
- Future work envision handling the webhook notification payload parsing
  in a more standardized way
- Related to #98

* Refactor tests to use sample fixture(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sorentwo @jbaugh @treble37