STL stores non-config data in ~/.config #486

MattSturgeon · 2022-06-06T23:39:26Z

Currently, STL stores everything in XDG_CONFIG_HOME (usually ~/.config), however the XDG spec recommends that directory only be used for configuration files.

Cache files, that can be replaced at any time (e.g. the downloads directory) would be better off in XDG_CACHE_HOME (~/.cache).

Persistent data, that isn't config files, would be better off in XDG_DATA_HOME (~/.local/share). The various WINEPREFIX/compatdatas (e.g. for mo2/vortex) are probably a good example of non-config data.

This might seem pretty, but applications storing stuff in the correct places can often make administering a system a lot simpler.

Similar to when stl's config directory changed from ~/.config/stl to ~/.config/steamtinkerlaunch, this would be a "breaking" change, so would benefit from a major version bump and clear release notes, although most users should be completely unaffected.

Storing stuff in XDG_CACHE_HOME may also highlight any existing bugs where wiping stl's cache breaks stuff. In principle, every time STL uses a file stored in XDG_CACHE_HOME, it should first check if the file exists and if not, re-download (or re-generate) it.

The text was updated successfully, but these errors were encountered:

frostworx · 2022-06-07T13:47:35Z

Nice and useful idea. I don't have much time, but try to help with the implementation when I find the time
(assuming this was an offer)

sonic2kk · 2022-06-08T23:34:19Z

I like this idea, but want to mention we should keep existing installations in mind. For things like MO2 which should go in $XDG_DATA_HOME we should think about having some way of moving these files around automatically if they're found.

Perhaps STL could check on startup to see if it's using the "old-style" file system (basically check what is present in ~/.config/steamtinkerlaunch, maybe like if [ -d "$STLCFGDIR/mo2" ]) and prompt a user. Something like this: "SteamTinkerLaunch v11.0 needs to run some extra configuration, please refer to the release notes for more information. Would you like to do it now? (This process is automatic but may take a while to complete)" With an option to accept or "Ask Again Next Launch." The line to refer to the release notes could have a link to the GitHub release page, and maybe we should also think about having an entry on the wiki on this once this feature is more finalised. I also recognise that this idea might take a considerable amount of testing.

Just my thoughts on how to make this kind of transition as simple as possible for an end user 🙂

frostworx · 2022-06-09T04:47:32Z

yeah, those migrations definitely need a (temporary) clean up function.
(I think in the past I removed them too quickly, so I'd keep it for about two version bumps if this comes life)

frostworx · 2022-06-30T13:53:35Z

hm, so no further discussion at all? 🤔

MattSturgeon · 2022-06-30T16:09:26Z

hm, so no further discussion at all? 🤔

Sorry I've been busy with work and other projects. Not sure if/when I'll have chance to work on this, but happy to if no one beats me to it 👍

frostworx · 2022-06-30T16:14:14Z

thanks for the reply.
no problem, I just bumped (almost) all open issues today.

Not sure if/when I'll have chance to work on this, but happy to if no one beats me to it +1

hehe, same :)

frostworx · 2022-08-03T17:58:38Z

zany130 · 2022-08-03T23:20:30Z

hmm not so sure about ~/.config/steamtinkerlaunch/backup being moved to .cacheas it's sometimes deleted by the user and I can see backups as something that you may not want to delete
so it may be better to put it in .local

same thing with ~/.config/steamtinkerlaunch/games/ not sure how I feel about that being in .cache while it's not something thats really that useful for the end user to go back to maybe it makes more sense for it to be in .local?

also noticed that downloads from some tools are being suggested for .cache and others for .local

that is fine as some downloads you don't really need anymore.

However it may just be easier to move the whole ~/.config/steamtinkerlaunch/downloads/ to ~/.local/share/steamtinkerlaunch/downloads/

maybe if anything some none essintial stuff can latter be moved to .cache

such as :

~/.config/steamtinkerlaunch/downloads/cheatengine

~/.config/steamtinkerlaunch/downloads/d3dcompiler_47

~/.config/steamtinkerlaunch/downloads/reshade

and instead of being ~/.cache/steamtinkerlaunch/downloads/reshade for example it can be ~/.cache/steamtinkerlaunch/reshade/

I think that makes more sense as .cache kinda already implies temp downloads and stuff like that

As for logs, I think they should be moved to ~/.local/steamtinkerlaunch/logs/

i didn't see you mention ~/.config/steamtinkerlaunch/meta/? think that can go in ~/.cache/steamtinkerlaunch/meta

zany130 · 2022-08-03T23:46:10Z

so it would look something like this

home
└── user
    ├── .cache
    │   └── steamtinkerlaunch
    │       ├── cheatengine
    │       ├── custom-fallback.png
    │       ├── d3dcompiler_47
    │     
    │       ├── protonlist.txt
    │       ├── protonrating
    │       │   ├── 1198090.json
    │       │   ├── 253230.json
    │       │   ├── 31337.json
    │       │   ├── 391540.json
    │       │   ├── 524220.json
    │       │   ├── 991270.json
    │       │   └── 992490.json
    │       ├── reshade
    │       ├── specialk
    │       └── temp
    │           └── dxvkcfg.txt
    ├── .config
    │   └── steamtinkerlaunch
    │       ├── collections
    │       ├── default_template.conf
    │       ├── dxvk
    │       ├── gamecfgs
    │       │   ├── customvars
    │       │   ├── id
    │       │   └── title
    │       ├── global.conf
    │       ├── guicfgs
    │       ├── hide
    │         ├── meta
    │       │   ├── eval
    │       │   │   ├── id
    │       │   │   ├── old
    │       │   │   └── title
    │       │   ├── id
    │       │   │   ├── custom
    │       │   │   └── general
    │       │   └── title
    │       │       ├── custom
    │       │       └── general
    │       ├── menublock.conf
    │       ├── menusort.conf
    │       ├── tweaks
    │       │   ├── cmd
    │       │   ├── sbs
    │       │   └── user
    │       └── url.conf
    └── .local
        └── share
            └── steamtinkerlaunch
                ├── backup
                │   ├── exclude
                │   └── steamuser
                │       ├── id
                │       └── title
                ├── cheatengine
                │   └── Cheat Engine 7.4
                ├── compatdata
                ├── downloads
                │   ├── proton
                │   │   └── custom
                │   ├── shaders
                │   ├── steamgriddb
                │   │   └── backup
                │   └── wine
                ├── games
                │   ├── appinfo
                │   ├── desktop
                │   ├── desktopfiles
                │   ├── header
                │   ├── icons
                │   │   ├── ico
                │   │   ├── png
                │   │   └── zip
                │   └── pev
                │       ├── peldd
                │       │   ├── id
                │       │   └── title
                │       ├── pepack
                │       │   ├── id
                │       │   └── title
                │       ├── peres
                │       │   ├── id
                │       │   └── title
                │       ├── pescan
                │       │   ├── id
                │       │   └── title
                │       ├── pesec
                │       │   ├── id
                │       │   └── title
                │       ├── pestr
                │       │   ├── id
                │       │   └── title
                │       └── readpe
                │           ├── id
                │           └── title
                ├── lang
                ├── logs
                │   ├── dxvk
                │   ├── gamelaunch
                │   │   ├── id
                │   │   └── title
                │   ├── playtime
                │   ├── proton
                │   │   ├── id
                │   │   └── title
                │   ├── steamtinkerlaunch
                │   │   ├── id
                │   │   ├── lastrun.txt
                │   │   └── title
                │   ├── vkd3d
                │   └── wine
                ├── mo2
                │   └── compatdata
                ├── proton
                │   └── custom
                ├── vortex
                │   ├── compatdata
                │   └── downloads
                └── wine

I moved ratings from ~/.config/steamtinkerlaunch/downloads/proton/ratings to ~/.cache/steamtinkerlaunch/protonratings/
as it makes more sense there

so basicly

.cache

~/.config/steamtinkerlaunch/downloads/cheatengine → ~/.cache/steamtinkerlaunch/cheatengine
~/.config/steamtinkerlaunch/downloads/d3dcompiler → ~/.cache/steamtinkerlaunch/d3dcompiler
~/.config/steamtinkerlaunch/downloads/proton/rating/ → ~/.cache/steamtinkerlaunch/protonrating/
~/.config/steamtinkerlaunch/downloads/reshade/ → ~/.cache/steamtinkerlaunch/reshade/
~/.config/steamtinkerlaunch/downloads/specialk/ → ~/.cache/steamtinkerlaunch/specialk/
~/.config/steamtinkerlaunch/temp/ → ~/.cache/steamtinkerlaunch/temp/
~/.config/steamtinkerlaunch/protonlist.txt → ~/.cache/steamtinkerlaunch/protonlist.txt/
~/.config/steamtinkerlaunch/downloads/custom-fallback.png → ~/.cache/steamtinkerlaunch/custom-fallback.png

.local

EDIT: didn't relize meta has config files for if you want to do a custom steamfirsttimerun script so that should stay in .config

frostworx · 2022-08-04T04:56:13Z

thanks for your suggestions.
Although being clean and nice, looking at it, it might be even more confusing for some users than the single config directory though.
Maybe the generally better approach would be to make those the corresponding directories simply overridable in the config, and let the user decide what they want (so 99% leaving the default settings untouched)

MattSturgeon · 2022-08-04T05:13:05Z

I think that makes more sense as .cache kinda already implies temp downloads and stuff like that

Not sure I agree with that. Temporary stuff should go in /tmp or similar. XDG_CACHE_HOME is persistent (non-volatile)... It isn't for temporary files, it's for files that are non-essential. Files that can be cached to increase performance, but can be replaced automatically if they disappear.

i.e. we can assume the files will be there for a while, but we shouldn't rely on it. Anything that STL can automatically replace probably belongs in .cache. Anything that is only needed briefly/occasionally and is cheap to replace could go in /tmp, although I don't think STL needs this.

Anything that can't be generated automatically is probably either data (.local/share) or config (.config).

hmm not so sure about ~/.config/steamtinkerlaunch/backup being moved to .cache [...] it may be better to put it in .local

Agreed, backups are "essential" data so shouldn't go in cache.

directories [could be] overridable in the config, and let the user decide what they want (so 99% leaving the default settings untouched)

Sure, config_dir, data_dir, cache_dir could make sense as config options. As long as they fallback to XDG spec when empty/unset. Could have additional more specific options too if needed (and not too complex) like download_dir for example...

As a stretch goal, it'd be nice if these options supported XDG env vars even when unset in the global environment. That way the user could reliably use variables in the config or they could be used in default values.

frostworx · 2022-08-04T05:21:31Z

Sure, config_dir, data_dir, cache_dir could make sense as config options. As long as they fallback to XDG spec when empty/unset

Sure, as in ea0ec14

Apparently I want to avoid spending much time into this feature. Of course it is nice to have for a few people, but the migration is much more complicated than just switching some paths.
I'll think about a sane solution shortly.

frostworx · 2022-08-07T06:55:39Z

I'm going to make a new release shortly and won't work very much on steamtinkerlaunch starting from then for various reasons.
So sorry, I won't add that feature anymore.
I will still stick around and occasionally add some things, but generally, I hope that the community rises with contributing PRs to keep the project alive.
(this one will be pretty much work when every obstacle is avoided, so I'd perfectly understand if it won't be implemented at all)

sonic2kk · 2022-09-22T16:58:04Z

I don't know if anyone is actively working on this but just a heads up if anyone ever does take a stab at this, ProtonUp-Qt's STL uninstaller will need to be updated. I don't think it's worth submitting anything to ProtonUp-Qt yet but in future, when all of the folders for the new directory structure are ironed out, the ProtonUp-Qt uninstallation logic will need updated to remove the folders.

So just as a note for the future if this ever does come to fruition, to keep this in mind before merging 😃

frostworx · 2022-09-22T16:59:49Z

Thanks for the heads-up! (I do not work on it and likely won't)

sonic2kk · 2022-11-02T01:12:32Z

This would be a behemoth of a task to be honest and while I am very much in favour of following the XDG spec, as it currently stands I am not super interested in doing it myself.

However if anyone wants to pick this up and work on it I would be more than happy to review and help out where possible with some knowledge. Some of the work was already started in ea0ec14 a while ago but I'm not sure how comprehensive it really is.

Also, various parts of the wiki would need updated off the back of this change. ProtonUp-Qt support and possibly Steam Deck (and maybe even Flatpak) support would need to be at least reviewed off the back of this. On top of this, there would probably need to be a migration path, which would be very delicate and need heavy testing.

Even though I don't want to do this myself, anyone passionate, willing and knowledgeable on what changes to make to best follow the XDG spec are very welcome to come forward and work on it. A fair warning, review on it could be lengthy and testing even moreso, but having this implemented would be a great change in my opinion. At the time of writing though, I have other things I would like to work on :-)

frostworx pushed a commit that referenced this issue Aug 3, 2022

initial skel for #486

ea0ec14

frostworx pushed a commit that referenced this issue Aug 4, 2022

minor for #486

9258d92

frostworx pushed a commit that referenced this issue Aug 4, 2022

#534, #486

20472cd

sonic2kk mentioned this issue Aug 25, 2022

Add steamtinkerlaunch source DavidoTek/ProtonUp-Qt#86

Closed

sonic2kk added the enhancement New feature or request label Sep 5, 2022

sonic2kk added the help wanted Features/Bug Fixes that welcome contributions label Nov 2, 2022

sonic2kk added the Initiative Issues detailing a significant set of features/enhancements label May 25, 2023

sonic2kk mentioned this issue Jun 7, 2023

Request: Help on reading the source code #822

Closed

sonic2kk mentioned this issue Oct 23, 2023

[Feature Request] Overhaul SteamGridDB Integration #933

Closed

11 tasks

sonic2kk mentioned this issue Mar 18, 2024

STL only crashes with Elden Ring #1067

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STL stores non-config data in ~/.config #486

STL stores non-config data in ~/.config #486

MattSturgeon commented Jun 6, 2022

frostworx commented Jun 7, 2022

sonic2kk commented Jun 8, 2022 •

edited

frostworx commented Jun 9, 2022

frostworx commented Jun 30, 2022

MattSturgeon commented Jun 30, 2022

frostworx commented Jun 30, 2022 •

edited

frostworx commented Aug 3, 2022

zany130 commented Aug 3, 2022 •

edited

zany130 commented Aug 3, 2022 •

edited

frostworx commented Aug 4, 2022

MattSturgeon commented Aug 4, 2022

frostworx commented Aug 4, 2022

frostworx commented Aug 7, 2022

sonic2kk commented Sep 22, 2022

frostworx commented Sep 22, 2022

sonic2kk commented Nov 2, 2022

STL stores non-config data in ~/.config #486

STL stores non-config data in ~/.config #486

Comments

MattSturgeon commented Jun 6, 2022

frostworx commented Jun 7, 2022

sonic2kk commented Jun 8, 2022 • edited

frostworx commented Jun 9, 2022

frostworx commented Jun 30, 2022

MattSturgeon commented Jun 30, 2022

frostworx commented Jun 30, 2022 • edited

frostworx commented Aug 3, 2022

zany130 commented Aug 3, 2022 • edited

zany130 commented Aug 3, 2022 • edited

frostworx commented Aug 4, 2022

MattSturgeon commented Aug 4, 2022

frostworx commented Aug 4, 2022

frostworx commented Aug 7, 2022

sonic2kk commented Sep 22, 2022

frostworx commented Sep 22, 2022

sonic2kk commented Nov 2, 2022

sonic2kk commented Jun 8, 2022 •

edited

frostworx commented Jun 30, 2022 •

edited

zany130 commented Aug 3, 2022 •

edited

zany130 commented Aug 3, 2022 •

edited