Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main window hijacks the Cmd+C keyboard shortcut when the About modal is focused #1394

Open
TomasHubelbauer opened this issue Aug 12, 2023 · 3 comments

Comments

@TomasHubelbauer
Copy link
Contributor

System information

  • SolveSpace version: Version 3.1 (3.1~70bde63c)
  • Operating system: macOS Ventura

Expected behavior

When on macOS and going to SolveSpace > About SolveSpace to be able to copy out the SolveSpace version in order to file for example a GitHub issue, when I select the SolveSpace version in the dialog window and press Cmd+C I see this modal:

image

Clearly the main window handles this shortcut combo despite the utility window being open and focused.
I am able to right-click and select Copy in the context menu to copy the version.

Actual behavior

The About SolveSpace window should not bubble the Cmd+C shortcut to the main window.

Additional information

This is a super minor thing but I thought it was still worth mentioning.

@jkrei0
Copy link

jkrei0 commented Aug 26, 2023

I'd like to add, that on windows, it isn't possible to select the text in the about dialog at all.

There is also Help > Go to GitHub Commit (not sure if it's different on macOS) which opens the commit in the browser, and you can copy from there.

@ruevs ruevs added the macOS label Sep 2, 2023
@ruevs
Copy link
Member

ruevs commented Sep 2, 2023

I'd like to add, that on windows, it isn't possible to select the text in the about dialog at all.

On Windows pressing CTRL+C while the About dialog is open copies all the text from it to the clipboard. This is true for any standard Windows message box and thus for all message boxes that SolveSpace shows.:

---------------------------
SolveSpace - Message
---------------------------
This is SolveSpace version 3.1~659215d8.

For more information, see http://solvespace.com/

SolveSpace is free software: you are free to modify
and/or redistribute it under the terms of the GNU
General Public License (GPL) version 3 or later.

There is NO WARRANTY, to the extent permitted by
law. For details, visit http://gnu.org/licenses/

© 2008-2023 Jonathan Westhues and other authors.

---------------------------
OK   
---------------------------

@ruevs ruevs added the UI label Sep 2, 2023
@phkahler
Copy link
Member

phkahler commented Sep 2, 2023

On Windows pressing CTRL+C while the About dialog is open copies all the text from it to the clipboard.

I didn't know that, but it's also way more inconvenient than selecting just the text of the version number ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants