Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the command in the lifecycle preStop hook via helm chart #9344

Open
sadieleob opened this issue Apr 9, 2024 · 1 comment
Labels
Type: Enhancement New feature or request zendesk

Comments

@sadieleob
Copy link

Gloo Edge Product

Enterprise

Gloo Edge Version

1.16.3

Is your feature request related to a problem? Please describe.

To enable the lifecycle hook in GE helm-chart we have gracefulShudown , enabling it in the helmCharts configures the following in the gateway-proxy deployment:

lifecycle:                                                                                                                                                                                                                        
    preStop:                                                                                                                                                                                                                         
        exec:                                                                                                                                                                                                                         
            command:                                                                                                                                                                                                                    
            - /bin/sh                                                                                                                                                                                                                   
            - -c                                                                                                                                                                                                                         
            - wget --post-data "" -O /dev/null 127.0.0.1:19000/healthcheck/fail; sleep                                                                                                                                                  
               15

The ask is to be able to customize the command via helm values.

Describe the solution you'd like

Allowing the customization of the command in the lifecycle preStop hook

Describe alternatives you've considered

The alternative is to use Kustomize or edit the deployment directly

Additional Context

No response

@sadieleob sadieleob added the Type: Enhancement New feature or request label Apr 9, 2024
@soloio-bot
Copy link

Zendesk ticket #3517 has been linked to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request zendesk
Projects
None yet
Development

No branches or pull requests

2 participants