We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookieStorage
maxAge
Create a persisted signal using cookieStorage and passing the maxAge option, but the created cookie is a session cookie.
In the linked StackBlitz project, click "Open in New Tab" button at top-right corner. Looks like it can't set cookies from an iframe.
const [maxAge, setMaxAge] = makePersisted(createSignal('initial'), { name: 'maxAge', storage: cookieStorage, storageOptions: { path: '/', maxAge: 60 * 60 * 24 * 7 }, }); const [expires, setExpires] = makePersisted(createSignal('initial'), { name: 'expires', storage: cookieStorage, storageOptions: { path: '/', expires: new Date(Date.now() + 60 * 60 * 24 * 7 * 1000), }, }); createEffect(() => { setMaxAge('hello'); setExpires('hello'); });
https://stackblitz.com/edit/github-n4ho5j-nffe5j?file=src%2Froutes%2Findex.tsx
The text was updated successfully, but these errors were encountered:
I confirm this error
Sorry, something went wrong.
The problem is serializeCookieOptions doesn't convert maxAge to max-age
serializeCookieOptions
max-age
Thanks, will fix.
Successfully merging a pull request may close this issue.
Describe the bug
Create a persisted signal using
cookieStorage
and passing themaxAge
option, but the created cookie is a session cookie.In the linked StackBlitz project, click "Open in New Tab" button at top-right corner. Looks like it can't set cookies from an iframe.
Minimal Reproduction Link
https://stackblitz.com/edit/github-n4ho5j-nffe5j?file=src%2Froutes%2Findex.tsx
The text was updated successfully, but these errors were encountered: