Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display data types when comparing data #161

Open
solemnwarning opened this issue Apr 19, 2022 · 1 comment
Open

Display data types when comparing data #161

solemnwarning opened this issue Apr 19, 2022 · 1 comment
Labels
feature A new feature

Comments

@solemnwarning
Copy link
Owner

Its not entirely clear how this should work yet - when different files have different data types defined etc. DiffWindow and DocumentCtrl will also need some rework to be able to vertically align the different regions in cases where they don't all have exactly the same height.

Requested by krisgnyc on Reddit.

@solemnwarning solemnwarning added the feature A new feature label Apr 19, 2022
@solemnwarning solemnwarning added this to the 0.60.2 milestone Oct 28, 2023
@solemnwarning
Copy link
Owner Author

This is annoyingly complicated.

Not only do we have to deal with vertical alignment between the regions, which I was intending to solve by populating all the regions as normal, then splitting/divinding and adding padding as needed once each region had computed past the point where alignment was lost but could be corrected, we also need to worry about preserving correct alignment within regions (e.g. instruction boundaries) and not fucking that up when collapsing similar sections.

I'm thinking data type classes should be able to take a more active role in analysing files, and the results of that analysis could be stored in the Document and then queried by regions, so the disassembly and subdivision would be performed within Document once a range was set up as machine code (for example), and the DisassemblyRegion class would consult Document to know where instruction boundaries were.

@solemnwarning solemnwarning removed this from the 0.60.2 milestone Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

1 participant