Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lamports_per_signature in nonce account is not used #34864

Open
tao-stones opened this issue Jan 20, 2024 · 0 comments
Open

lamports_per_signature in nonce account is not used #34864

tao-stones opened this issue Jan 20, 2024 · 0 comments

Comments

@tao-stones
Copy link
Contributor

Problem

nonce account holds a fee_calculator that provides lamports_per_signature. However this lamports_per_signature is not used:

  1. calculate_fee(...) uses fee_structure.lamports_per_siganture to calculate signature fee;
  2. process_message(...) passes last block_hash's lamports_per_signature to transaction processing.

Proposed Solution

  1. remove fee_calculator and lamports_per_signature() from nonce account
  2. remove code (such as this) that fetches lamports_per_signature before calling calculate_fee(...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant