Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseButton does not seem to respect TouchableWithoutFeedback #992

Open
chrisdrackett opened this issue Feb 28, 2020 · 4 comments
Open

BaseButton does not seem to respect TouchableWithoutFeedback #992

chrisdrackett opened this issue Feb 28, 2020 · 4 comments

Comments

@chrisdrackett
Copy link

chrisdrackett commented Feb 28, 2020

I have a ScrollView with keyboardShouldPersistTaps set to never. If I put a TouchableWithoutFeedback from react-native and a TextInput in this view tapping the TouchableWithoutFeedback does not trigger its onPress and only blurs the TextInput. If I however replace the TouchableWithoutFeedback with a BaseButton from this package tapping the button both blurs the view and activates the onPress on BaseButton.

@jakub-gonet
Copy link
Member

If it's still relevant, could you provide some small repro?

@chrisdrackett
Copy link
Author

let me see if I can even remember where we ran into this and if I can reproduce!

@chrisdrackett
Copy link
Author

I think I probably have a typo above, I'm guessing the first TouchableWithoutFeedback should be keyboardShouldPersistTaps

@chrisdrackett
Copy link
Author

ok, here is a working example: https://snack.expo.io/@tiltshift/cf2c6f

when the input is focused at the bottom of the card if you press "baseButton" the button press count at the top will update. This is inconsistent with the behavior we get with the native TouchableWithoutFeedback where the count value does not update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants