-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thoughts about making UnixStream public #50
Comments
Resolves softprops#50 Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
The choice to keep the inner @fnichol Just in case. |
Resolves softprops#50 Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
hyper does not expose the inner TcpStream, but the AddrStream itself is exposed in the public interface? |
Oh, I completely missed that I agree that making @softprops Would you like to delegate maintenance of this project to help manage some of the outstanding PRs? |
Resolves softprops#50 Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
馃憢 I'm looking at using this logic as part of my own HTTP Client, and I was hoping to get access to the
UnixStream
type: https://github.com/softprops/hyperlocal/blob/main/src/client.rs#L19.The main reason i'm doing this all is to honestly have hyper tuned error reporting. Certain IO Error codes mean certain things depending on the stream type, and by wrapping everything in my own custom enums I can make decisions/keep state about the streams, connectors, etc. In any part of my codebase.
I realize most people get fine without it though, and I imagine it was made private for a reason, so I just wanted to see if there was any chance we could start exporting that type.
The text was updated successfully, but these errors were encountered: