Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't there documentation for handlePreflightRequest? #3334

Closed
ghost opened this issue Sep 19, 2018 · 5 comments
Closed

Why isn't there documentation for handlePreflightRequest? #3334

ghost opened this issue Sep 19, 2018 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@ghost
Copy link

ghost commented Sep 19, 2018

It's not documented as an option here: https://github.com/socketio/socket.io/blob/master/docs/API.md#new-serverhttpserver-options

Even though this works: socketio/socket.io-client#1140 (comment)

@siddhant1
Copy link

Should i work on this one?

@5ebastianMeier
Copy link

Another problem is that this solution works perfectly, but breaks in an TypeScript environment because the typings in the package @types/socket.io also don't contain the option.

@NoniHunter
Copy link

NoniHunter commented Jan 6, 2019

Already documented here https://github.com/socketio/engine.io#methods-1 as part of Engine.IO.

@EO2875
Copy link

EO2875 commented Nov 13, 2020

Yeah, this isn't a part of Socket.IO but of Express JS. These docs do show that option, but they link they reference "for mroe detail" does not show it.

@darrachequesne
Copy link
Member

Documentation for v2: https://socket.io/docs/v2/handling-cors/

Documentation for v3: https://socket.io/docs/v3/handling-cors/

@darrachequesne darrachequesne added the documentation Improvements or additions to documentation label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants