Failing to load the file in IE #1328

shyam1992 · 2019-09-25T13:24:45Z

t.log = function(...e) {
return "object" == typeof console && console.log && console.log(...e)
}
this code fails to execute in IE11.
Expected Identifier error.

jmaslin · 2019-09-25T18:27:39Z

Same here on v2.3.0 and IE 11

shyam1992 · 2019-09-26T06:05:30Z

Same here on v2.3.0 and IE 11

We reverted back to 2.2.0 and it is woking fine.

fmoessle · 2019-09-26T09:09:07Z

I also reverted to 2.2.0 and it works fine. Seems like the code exported by the module is not valid ES5.

darrachequesne · 2019-09-27T07:40:44Z

Well, it shoud have been transpiled by babel... I'll take a look at this. Le jeu. 26 sept. 2019 à 11:09, orangejuice <notifications@github.com> a écrit :

…

I also reverted to 2.2.0 and it works fine. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1328?email_source=notifications&email_token=ADDNSFI5LWY4MJXY24WZNNLQLR333A5CNFSM4I2MYYBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7U4IVQ#issuecomment-535413846>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADDNSFNC7OUW4Z3BEWLSNRLQLR333ANCNFSM4I2MYYBA> .

rafalmaciejewski · 2019-09-30T11:46:13Z

This happened after updating debug from v3 to v4 which uses spread operator in its distributable.
Very often node_modules are excluded from babel compilation for performance reasons.

dalyr95 · 2019-10-21T11:05:08Z

Got this in IE11 as well.

"SyntaxError: Syntax error
   at ../node_modules/socket.io-client/node_modules/debug/src/browser.js (http://192.168.86.48:3000/static/vendors~vehicle-Vehicle.jsx.eb6d2ebd6bfc7172757c.js:510:1)
   at __webpack_require__ (http://192.168.86.48:3000/static/client.js?1571655164758:107:12)
   at eval code (eval code:7:1)
   at ../node_modules/socket.io-client/lib/url.js (http://192.168.86.48:3000/static/vendors~vehicle-Vehicle.jsx.eb6d2ebd6bfc7172757c.js:488:1)
   at __webpack_require__ (http://192.168.86.48:3000/static/client.js?1571655164758:107:12)
   at eval code (eval code:6:1)
   at ../node_modules/socket.io-client/lib/index.js (http://192.168.86.48:3000/static/vendors~vehicle-Vehicle.jsx.eb6d2ebd6bfc7172757c.js:444:1)
   at __webpack_require__ (http://192.168.86.48:3000/static/client.js?1571655164758:107:12)
   at eval code (eval code:55:22)
   at ./shared/components/catalogue/ValuationCatalogue.jsx (http://192.168.86.48:3000/static/vehicle-Vehicle.jsx.b7e97db41986fa53caa6.js:344:1)"

Affected lines

/**
 * Invokes `console.log()` when available.
 * No-op when `console.log` is not a "function".
 *
 * @api public
 */
function log(...args) {
	// This hackery is required for IE8/9, where
	// the `console.log` function doesn't have 'apply'
	return typeof console === 'object' &&
		console.log &&
		console.log(...args);
}

Don't really have much to add as it's been identified as non transpiled code.

shusiwei · 2019-10-23T05:54:47Z

Same here on v2.3.0 and IE 11

and iOS9 Safari

dalyr95 · 2019-10-23T20:25:50Z

This is a breaking change on a point release that we got automatically upgraded too. For those who still support IE11 this is quite serious, took us a few days to realise.

christosv94 · 2019-10-28T11:35:06Z

How long do you expect to take them to fix the issue?

ErfanNaz · 2020-01-29T15:37:37Z

this issue is related to debug:4.1.0 They have already replaced the method but sill no new build where this issue is fixed.

fix for socket.io-client and engine.io-client would be to replace the current version debug with version 4.0.1.

stnwk · 2020-02-06T15:04:23Z

Unfortunately, it seems like the maintainer of debug is not willing to hear our problem at all: debug-js/debug#668 (comment)

stnwk · 2020-02-06T15:09:17Z

Hi @darrachequesne :)

Can you please pin the debug package for socket.io-client to 4.0.1? Thank you!

stnwk · 2020-02-06T15:42:01Z

In the mean time I tried to approach the maintainer of debug and asked him to please re-consider his choice not to transpile the package to ES5 code anymore: debug-js/debug#745

Qix- · 2020-02-06T16:41:33Z

I've heard the problem a thousand times. I've heard it since the problem was first created. Please transpile your application if you want it to work on archaic browsers; debug is just the first of many dependencies you'll run into that are written and published as ES6 modules.

Very often node_modules are excluded from babel compilation for performance reasons.

This doesn't mean package maintainers should keep their code pinned to the stone ages. The javascript ecosystem is slow, yes, but it's even slower when e.g. IE11 keeps us held back. The reason why debug is picked on a lot is because it's one of the top 10 most depended upon packages and thus is usually one of the first packages to encounter errors or issues, even though 100's of other dependencies will slow you down, too.

If you don't believe me, manually transpile debug in your node_modules and try to bundle your app again. Most likely, depending on the size of your application, the bundling process will fail elsewhere.

If you have a problem with Babel's efficiency, open an issue at Babel. If you have a problem with CRA not performing proper transpilation, open an issue with CRA.

I don't want to come off as dismissive; this just isn't debug's problem.

jsilveira2 · 2020-02-07T11:54:00Z

From what they say in this link here. It seems to be a babel configuration problem, maybe if the staff changes the configuration inside the socket-io-client it can solve the problem.

Qix- · 2020-02-07T14:41:49Z

Correct; that is the official response from the Babel team. Please take your issues there.

rafalmaciejewski · 2020-02-07T15:12:09Z

What official response? Linked issue was about babel not transpiling selected packages from node_modules when configured to, and it's fixed.

Socket.io-client doesn't even use babel for transpiling. It only uses webpack to bundle all dependencies into a single distributable.

So now, if socket.io-client is to be supported in older browsers it needs either a transpilation step while building or it needs to downgrade or replace debug.

Publishing packages for web that need transpilation is actually not that common. Over the years of transpiling i encountered it only a few times even on projects with literally GBs of dependencies in node_modules. Until now every maintainer was nice enough to treat it as a bug...

Qix- · 2020-02-07T15:31:00Z

This is the response I was referring to:

I agree that this is not a debug bug, but a problem with how Babel has been configured.

If you configure Babel to transpile node modules but it still isn't working, please provide a minimal repository I can clone to investigate.

So now, if socket.io-client is to be supported in older browsers it needs . . . a transpilation step

Correct. That is the state of modern web development.

with literally GBs of dependencies in node_modules

This is the real problem. Not debug choosing not to transpile. By using ES6 modules, this is generally not an issue because your application will only bundle the dependencies it uses, and thus will only transpile the dependencies it uses. People do this to great effect every day.

Until now every maintainer was nice enough to treat it as a bug...

Using perfectly valid versions of Javascript is not a bug.

rafalmaciejewski · 2020-02-07T15:59:35Z

Saying transpile node_modules instead of publishing a package that supports as many active environments as possible is such a middle finger to anyone running a business.
I need to carefully select each package to transpile since transpiling everything from node_modules more than quadruples build time of some projects - sometimes from several minutes to an hour. Nobody has time for that.
Today more people are still using IE11 than Firefox. IE11 is still supported by Microsoft. I don't think that forcing personal beliefs about JS community not moving fast enough is really doing any good.

Qix- · 2020-02-07T16:03:39Z

Saying transpile node_modules instead of publishing a package that supports as many active environments as possible is such a middle finger to anyone running a business.

That's not really a constructive attitude, and not the kind of discourse I'd like to have in open source, personally.

I think I've said my piece here. Sorry my decision to improve the maintainability of a module downloaded nearly 60 million times a week doesn't fit your business model.

rautex · 2020-02-10T14:48:46Z

Today more people are still using IE11 than Firefox. IE11 is still supported by Microsoft. I don't think that forcing personal beliefs about JS community not moving fast enough is really doing any good.

the problem in this case is more thaht companies using ie11 massive, after my logs 25% of my visitors come by ie.

I would like to show the middle finger to ie but when u run a business u cant send them to hell because u want there money :)

jeremylcarter · 2020-02-17T22:28:27Z

What is the current workaround for this issue?

rautex · 2020-02-17T22:30:33Z

What is the current workaround for this issue?

2.2.0 when u can after fmoessle

tomtom94 · 2020-03-19T14:13:58Z

Took me 3 days to find out the bug was coming from socket.io-client module lol

Me too I downgrade module version to 2.2.0 cheers all

govinddk4444 · 2020-03-23T14:53:13Z

Downgrading to 2.2.0 worked for me as well. Thanks.

Rob-ot · 2020-04-15T00:29:22Z

Maybe a good solution is to switch socket.io to this fork of debug debug-es5 that is transpiled to es5.

I've spent an entire day trying to get babel and webpack to transpile debug/src/browser.js and from the many threads I've stumbled on it seems like a lot of people are running into this too. Seems like a lot of engineering time that could be saved.

By the way, socket.io v2.2.0 has a memory leak that was fixed in 'ws' v7.1.2 (websockets/ws#1617) so be careful downgrading.

Edit: got it fixed
Most posts I found were recommending to stop excluding /node_modules/ from webpack but this didn't work and also is slow. (pretty sure webpack was hitting the file but babel wasn't transpiling it, maybe related to babel/preset-env)

Instead, I just installed debug-es5 and had webpack use that in place of debug by adding this to the webpack.config.js

  resolve: {
    alias: {
      debug: 'debug-es5',
    },
  },

kmaraz · 2020-04-15T08:28:51Z

I am using:

{
  test: /\.js$/,
  use: babelLoader,
  exclude: excludeNodeModulesExcept(['debug']),
},

const babelLoader = {
    loader: 'babel-loader',
    options: {
      // Don't waste time on Gzipping the cache
      cacheCompression: false,
      // This is a feature of `babel-loader` for webpack (not Babel itself).
      // It enables caching results in ./node_modules/.cache/babel-loader/
      // directory for faster rebuilds.
      cacheDirectory: true,
      plugins: ['@babel/plugin-syntax-dynamic-import'],
      presets: [['@babel/env', { modules: false }]],
      sourceMaps: includeSourcemap && !isDevelopmentMode,
    },
  };

const excludeNodeModulesExcept = function (modules) {
  var pathSep = path.sep;
  if (pathSep == '\\')
    // must be quoted for use in a regexp:
    pathSep = '\\\\';
  var moduleRegExps = modules.map(function (modName) {
    return new RegExp('node_modules' + pathSep + modName);
  });

  return function (modulePath) {
    if (/node_modules/.test(modulePath)) {
      for (var i = 0; i < moduleRegExps.length; i++)
        if (moduleRegExps[i].test(modulePath)) return false;
      return true;
    }
    return false;
  };
};

craigPeckett · 2020-04-15T22:56:06Z

changing socket.io-client to 2.2.0 works for me but only after building and starting the application.

in dev mode I still get the error

TypeError: Object doesn't support property or method 'cbrt'
{
[functions]: ,
proto: { },
description: "Object doesn't support property or method 'cbrt'",
message: "Object doesn't support property or method 'cbrt'",
name: "TypeError",
number: -2146827850,
stack: "TypeError: Object doesn't support property or method 'cbrt'
at cielabForwardTransform (eval code:39754:3)
at fromXYZ (eval code:39763:3)
at lighten (eval code:39706:3)
at genVariations (eval code:39696:5)
at parse (eval code:39606:7)
at parsedTheme.get (eval code:39498:7)
at generatedStyles.get (eval code:39466:7)
at Theme.prototype.applyTheme (eval code:39297:5)
at handler (eval code:39449:13)
at Vue.prototype.$watch (eval code:4941:9)",
Symbol(Lang fallback)_i.t81c9tw05xo: undefined,
Symbol(react.element)_h.t81c9tw05xo: undefined,
Symbol(stop)_n.t81c9tw05xo: undefined
}

laxell · 2020-09-06T07:08:02Z

Maybe a good solution is to switch socket.io to this fork of debug debug-es5 that is transpiled to es5.

I've spent an entire day trying to get babel and webpack to transpile debug/src/browser.js and from the many threads I've stumbled on it seems like a lot of people are running into this too. Seems like a lot of engineering time that could be saved.

By the way, socket.io v2.2.0 has a memory leak that was fixed in 'ws' v7.1.2 (websockets/ws#1617) so be careful downgrading.

Edit: got it fixed
Most posts I found were recommending to stop excluding /node_modules/ from webpack but this didn't work and also is slow. (pretty sure webpack was hitting the file but babel wasn't transpiling it, maybe related to babel/preset-env)

Instead, I just installed debug-es5 and had webpack use that in place of debug by adding this to the webpack.config.js
  resolve: {
    alias: {
      debug: 'debug-es5',
    },
  },

This saved me hours of work - thank you!

kmaraz · 2020-09-08T00:31:39Z

I have created a very small repo with this issue solved with basic Webpack configuration: https://github.com/kmaraz/debug-to-es5

darrachequesne · 2020-09-30T21:37:45Z

The debug dependency was reverted to 3.1.0, which does not need to be transpiled. Released in 2.3.1.

Please note that you can also use the webpack-remove-debug plugin, in order to remove any call to the debug dependency (until we find a proper way to provide a build with and without debug).

qiulang · 2021-06-22T10:27:14Z

This is an old issue but I need to add this, even with 'webpack-remove-debug' I still failed to make 4.x work on IE 11.

I have gave it up, don't think worth effort any more. 😱

{
    module: {
        rules: [
            {
				test: './node_modules/**/debug/**/*.js',
				loader: 'webpack-remove-debug'
			}
        ]
    }
};

darrachequesne · 2021-06-22T11:47:56Z

@qiulang please check our own webpack configuration: https://github.com/socketio/socket.io-client/blob/master/support/webpack.config.js

zzkkui · 2023-11-10T12:41:21Z

I am using:

{
  test: /\.js$/,
  use: babelLoader,
  exclude: excludeNodeModulesExcept(['debug']),
},

const babelLoader = {
    loader: 'babel-loader',
    options: {
      // Don't waste time on Gzipping the cache
      cacheCompression: false,
      // This is a feature of `babel-loader` for webpack (not Babel itself).
      // It enables caching results in ./node_modules/.cache/babel-loader/
      // directory for faster rebuilds.
      cacheDirectory: true,
      plugins: ['@babel/plugin-syntax-dynamic-import'],
      presets: [['@babel/env', { modules: false }]],
      sourceMaps: includeSourcemap && !isDevelopmentMode,
    },
  };

const excludeNodeModulesExcept = function (modules) {
  var pathSep = path.sep;
  if (pathSep == '\\')
    // must be quoted for use in a regexp:
    pathSep = '\\\\';
  var moduleRegExps = modules.map(function (modName) {
    return new RegExp('node_modules' + pathSep + modName);
  });

  return function (modulePath) {
    if (/node_modules/.test(modulePath)) {
      for (var i = 0; i < moduleRegExps.length; i++)
        if (moduleRegExps[i].test(modulePath)) return false;
      return true;
    }
    return false;
  };
};

This does not work for me, I found that babel/core also uses debug@4

This was referenced Nov 13, 2019

What did debug 4 introduce to make babel fails to polyfill IE 11? debug-js/debug#729

Closed

@babel/preset-env fails to polyfill IE11 for debug module, version 4 babel/babel#10707

Closed

christosv94 mentioned this issue Nov 26, 2019

2.3.0 with mobile error #1340

Closed

darrachequesne closed this as completed Sep 30, 2020

darrachequesne added this to the 2.3.1 milestone Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failing to load the file in IE #1328

Failing to load the file in IE #1328

shyam1992 commented Sep 25, 2019

jmaslin commented Sep 25, 2019

shyam1992 commented Sep 26, 2019

fmoessle commented Sep 26, 2019 •

edited

darrachequesne commented Sep 27, 2019 via email

rafalmaciejewski commented Sep 30, 2019

dalyr95 commented Oct 21, 2019

shusiwei commented Oct 23, 2019

dalyr95 commented Oct 23, 2019

christosv94 commented Oct 28, 2019

ErfanNaz commented Jan 29, 2020 •

edited

stnwk commented Feb 6, 2020 •

edited

stnwk commented Feb 6, 2020

stnwk commented Feb 6, 2020

Qix- commented Feb 6, 2020 •

edited

jsilveira2 commented Feb 7, 2020 •

edited

Qix- commented Feb 7, 2020

rafalmaciejewski commented Feb 7, 2020

Qix- commented Feb 7, 2020

rafalmaciejewski commented Feb 7, 2020

Qix- commented Feb 7, 2020

rautex commented Feb 10, 2020

jeremylcarter commented Feb 17, 2020

rautex commented Feb 17, 2020

tomtom94 commented Mar 19, 2020

govinddk4444 commented Mar 23, 2020

Rob-ot commented Apr 15, 2020 •

edited

kmaraz commented Apr 15, 2020

craigPeckett commented Apr 15, 2020

laxell commented Sep 6, 2020

kmaraz commented Sep 8, 2020

darrachequesne commented Sep 30, 2020

qiulang commented Jun 22, 2021 •

edited

darrachequesne commented Jun 22, 2021

zzkkui commented Nov 10, 2023

Failing to load the file in IE #1328

Failing to load the file in IE #1328

Comments

shyam1992 commented Sep 25, 2019

jmaslin commented Sep 25, 2019

shyam1992 commented Sep 26, 2019

fmoessle commented Sep 26, 2019 • edited

darrachequesne commented Sep 27, 2019 via email

rafalmaciejewski commented Sep 30, 2019

dalyr95 commented Oct 21, 2019

shusiwei commented Oct 23, 2019

dalyr95 commented Oct 23, 2019

christosv94 commented Oct 28, 2019

ErfanNaz commented Jan 29, 2020 • edited

stnwk commented Feb 6, 2020 • edited

stnwk commented Feb 6, 2020

stnwk commented Feb 6, 2020

Qix- commented Feb 6, 2020 • edited

jsilveira2 commented Feb 7, 2020 • edited

Qix- commented Feb 7, 2020

rafalmaciejewski commented Feb 7, 2020

Qix- commented Feb 7, 2020

rafalmaciejewski commented Feb 7, 2020

Qix- commented Feb 7, 2020

rautex commented Feb 10, 2020

jeremylcarter commented Feb 17, 2020

rautex commented Feb 17, 2020

tomtom94 commented Mar 19, 2020

govinddk4444 commented Mar 23, 2020

Rob-ot commented Apr 15, 2020 • edited

kmaraz commented Apr 15, 2020

craigPeckett commented Apr 15, 2020

laxell commented Sep 6, 2020

kmaraz commented Sep 8, 2020

darrachequesne commented Sep 30, 2020

qiulang commented Jun 22, 2021 • edited

darrachequesne commented Jun 22, 2021

zzkkui commented Nov 10, 2023

fmoessle commented Sep 26, 2019 •

edited

ErfanNaz commented Jan 29, 2020 •

edited

stnwk commented Feb 6, 2020 •

edited

Qix- commented Feb 6, 2020 •

edited

jsilveira2 commented Feb 7, 2020 •

edited

Rob-ot commented Apr 15, 2020 •

edited

qiulang commented Jun 22, 2021 •

edited